Bug 221543 - [SOUP] Simplify ResourceRequest and ResourceResponse
Summary: [SOUP] Simplify ResourceRequest and ResourceResponse
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks: libsoup3
  Show dependency tree / graph
 
Reported: 2021-02-08 04:10 PST by Carlos Garcia Campos
Modified: 2021-02-10 01:42 PST (History)
6 users (show)

See Also:

Attachments
Patch (28.98 KB, patch)
2021-02-08 04:33 PST, Carlos Garcia Campos 		aperez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2021-02-08 04:10:43 PST 
There's unused code there and it can be refactored a bit
Comment 1 Carlos Garcia Campos 2021-02-08 04:33:33 PST 
Created attachment 419573 [details]
Patch
Comment 2 Adrian Perez 2021-02-08 07:13:10 PST 
Comment on attachment 419573 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419573&action=review

> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:63
> +    GRefPtr<SoupMessage> soupMessage = adoptGRef(soup_message_new_from_uri(httpMethod().ascii().data(), uri.get()));

I would have used “auto” here because the “adoptGRef()” + “soup_message_new_foo()”
calls already make it quite clear that the inferred type will be “GRefPtr<SoupMessage>”
No strong preference, though.

> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:-174
> -

Nice to see some code go away \o/
Comment 3 Carlos Garcia Campos 2021-02-10 01:41:26 PST 
Committed r272641: <https://trac.webkit.org/changeset/272641>
Comment 4 Radar WebKit Bug Importer 2021-02-10 01:42:14 PST 
<rdar://problem/74180921>