Bug 221535 – Reduce the overhead of DocumentFragment in innerHTML & outerHTML

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

We should cache DocumentFragment used in innerHTML and outerHTML,
and avoid calling removedFromAncestor on each node when removing from DocumentFragment.

[Ryosuke Niwa]

Created attachment 419552 [details]
WIP

[Ryosuke Niwa]

<rdar://problem/73861015>

[Ryosuke Niwa]

Created attachment 419797 [details]
Patch

[Ryosuke Niwa]

Created attachment 419802 [details]
Patch

[Geoffrey Garen]

Comment on attachment 419802 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419802&action=review

r=me

> Source/WTF/wtf/WeakPtr.h:180
> +    bool hasWeakReferences() const { return m_impl; }

I would call this isInitialized().

Knowing that m_impl is non-null only tells us that someone created a reference at some point - not that the reference still exists.

[Ryosuke Niwa]

(In reply to Geoffrey Garen from comment #5)
> Comment on attachment 419802 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=419802&action=review
> 
> r=me
> 
> > Source/WTF/wtf/WeakPtr.h:180
> > +    bool hasWeakReferences() const { return m_impl; }
> 
> I would call this isInitialized().
> 
> Knowing that m_impl is non-null only tells us that someone created a
> reference at some point - not that the reference still exists.

Good point. The alternative name I had considered as hasEverCreatedWeakPtr but maybe isInitialized okay although it's really hasBeenInitialized

[Ryosuke Niwa]

Committed r272703: <https://trac.webkit.org/changeset/272703>