Bug 221534 – libwebrtc installs some files into incorrect locations in /usr/local/include

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Alexey Proskuryakov]

In what looks like project configuration mistakes, libWebRTC installs:

- optional.h into /usr/local/include instead of somewhere inside /usr/local/include/webrtc;
- vp9_header_parser.h into /usr/local/include/common.

I don't know of any immediate problems this causes, but this seems like undesirable namespace pollution.

[Radar WebKit Bug Importer]

<rdar://problem/74333613>

[youenn fablet]

This is a left over for optional.h and I guess could be removed.
Not sure why vp9_header_parser.h could not be put in /usr/local/include/webm

[youenn fablet]

Created attachment 420443 [details]
Patch

[EWS]

Committed r272914: <https://commits.webkit.org/r272914>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420443 [details].

[WebKit Commit Bot]

Re-opened since this is blocked by bug 222001

[youenn fablet]

Created attachment 420816 [details]
Patch for landing

[EWS]

The 'validate-changelog' command is currently deprecated due to believed non-use; if it forms part of your workflow, please comment on https://bugs.webkit.org/show_bug.cgi?id=221991 and please include the command you ran, even if others have already mentioned it
ChangeLog entry in Source/ThirdParty/libwebrtc/ChangeLog contains OOPS!.

[youenn fablet]

Created attachment 420819 [details]
Patch for landing

[EWS]

Found 1 new test failure: media/modern-media-controls/volume-support/volume-support-drag.html

[EWS]

Committed r273089: <https://commits.webkit.org/r273089>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420819 [details].