Bug 221534 - libwebrtc installs some files into incorrect locations in /usr/local/include
Summary: libwebrtc installs some files into incorrect locations in /usr/local/include
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 222001
Blocks:
  Show dependency tree / graph
 
Reported: 2021-02-07 18:06 PST by Alexey Proskuryakov
Modified: 2021-02-18 13:30 PST (History)
6 users (show)

See Also:

Attachments
Patch (22.11 KB, patch)
2021-02-16 02:31 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (8.85 KB, patch)
2021-02-18 02:32 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (8.85 KB, patch)
2021-02-18 03:14 PST, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2021-02-07 18:06:04 PST 
In what looks like project configuration mistakes, libWebRTC installs:

- optional.h into /usr/local/include instead of somewhere inside /usr/local/include/webrtc;
- vp9_header_parser.h into /usr/local/include/common.

I don't know of any immediate problems this causes, but this seems like undesirable namespace pollution.
Comment 1 Radar WebKit Bug Importer 2021-02-14 18:07:12 PST 
<rdar://problem/74333613>
Comment 2 youenn fablet 2021-02-16 02:25:57 PST 
This is a left over for optional.h and I guess could be removed.
Not sure why vp9_header_parser.h could not be put in /usr/local/include/webm
Comment 3 youenn fablet 2021-02-16 02:31:22 PST 
Created attachment 420443 [details]
Patch
Comment 4 EWS 2021-02-16 10:07:36 PST 
Committed r272914: <https://commits.webkit.org/r272914>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420443 [details].
Comment 5 WebKit Commit Bot 2021-02-16 14:45:22 PST 
Re-opened since this is blocked by bug 222001
Comment 6 youenn fablet 2021-02-18 02:32:42 PST 
Created attachment 420816 [details]
Patch for landing
Comment 7 EWS 2021-02-18 03:10:18 PST 
The 'validate-changelog' command is currently deprecated due to believed non-use; if it forms part of your workflow, please comment on https://bugs.webkit.org/show_bug.cgi?id=221991 and please include the command you ran, even if others have already mentioned it
ChangeLog entry in Source/ThirdParty/libwebrtc/ChangeLog contains OOPS!.
Comment 8 youenn fablet 2021-02-18 03:14:19 PST 
Created attachment 420819 [details]
Patch for landing
Comment 9 EWS 2021-02-18 06:10:46 PST 
Found 1 new test failure: media/modern-media-controls/volume-support/volume-support-drag.html
Comment 10 EWS 2021-02-18 12:04:57 PST 
Committed r273089: <https://commits.webkit.org/r273089>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420819 [details].