[macOS] Return key binding for date inputs conflicts with return to submit form

[Aditya Keerthi]

Steps To Reproduce:
1. Go to https://www.w3schools.com/TAGS/tryit.asp?filename=tryhtml5_input_type_date
2. Press shift-TAB to focus the birthday field
3. Type a date
4. Press return

Observe that the calendar view is presented, and the form is not submitted.

[Aditya Keerthi]

<rdar://problem/74039204>

[Aditya Keerthi]

Created attachment 419544 [details]
Patch

[Wenson Hsieh]

Comment on attachment 419544 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419544&action=review

> Source/WebCore/html/BaseDateAndTimeInputType.cpp:421
> +    int charCode = event.charCode();

Nit - I'm not sure the local variable adds much here. Maybe just check (event.charCode() == '\r') below?

[Aditya Keerthi]

Created attachment 419546 [details]
Patch

[Aditya Keerthi]

Created attachment 419547 [details]
Patch for landing

[Aditya Keerthi]

(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 419544 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=419544&action=review
> 
> > Source/WebCore/html/BaseDateAndTimeInputType.cpp:421
> > +    int charCode = event.charCode();
> 
> Nit - I'm not sure the local variable adds much here. Maybe just check
> (event.charCode() == '\r') below?

Removed the local variable.

Thanks for the review!

[EWS]

commit-queue failed to commit attachment 419547 [details] to WebKit repository. To retry, please set cq+ flag again.

[EWS]

commit-queue failed to commit attachment 419547 [details] to WebKit repository. To retry, please set cq+ flag again.

[EWS]

Committed r272495: <https://commits.webkit.org/r272495>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419547 [details].