WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
221531
Remove a duplicate implementation of EventHandler::mouseDownMayStartSelect()
https://bugs.webkit.org/show_bug.cgi?id=221531
Summary
Remove a duplicate implementation of EventHandler::mouseDownMayStartSelect()
Wenson Hsieh
Reported
2021-02-07 11:41:37 PST
This method has both const and non-const implementations, but only the non-const version is used. We should remove the (currently unused) const version that just returns `m_mouseDownMayStartSelect`, and mark what is currently the non-`const` version `const` instead.
Attachments
Patch
(3.83 KB, patch)
2021-02-07 11:45 PST
,
Wenson Hsieh
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Wenson Hsieh
Comment 1
2021-02-07 11:45:57 PST
Created
attachment 419543
[details]
Patch
Wenson Hsieh
Comment 2
2021-02-07 13:56:43 PST
Comment on
attachment 419543
[details]
Patch Thanks for the review!
EWS
Comment 3
2021-02-07 14:10:44 PST
Committed
r272477
: <
https://commits.webkit.org/r272477
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 419543
[details]
.
Radar WebKit Bug Importer
Comment 4
2021-02-10 14:35:32 PST
<
rdar://problem/74206753
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug