Bug 221531 - Remove a duplicate implementation of EventHandler::mouseDownMayStartSelect()
Summary: Remove a duplicate implementation of EventHandler::mouseDownMayStartSelect()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-07 11:41 PST by Wenson Hsieh
Modified: 2021-02-10 14:35 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.83 KB, patch)
2021-02-07 11:45 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-02-07 11:41:37 PST 
This method has both const and non-const implementations, but only the non-const version is used.

We should remove the (currently unused) const version that just returns `m_mouseDownMayStartSelect`, and mark what is currently the non-`const` version `const` instead.
Comment 1 Wenson Hsieh 2021-02-07 11:45:57 PST 
Created attachment 419543 [details]
Patch
Comment 2 Wenson Hsieh 2021-02-07 13:56:43 PST 
Comment on attachment 419543 [details]
Patch

Thanks for the review!
Comment 3 EWS 2021-02-07 14:10:44 PST 
Committed r272477: <https://commits.webkit.org/r272477>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419543 [details].
Comment 4 Radar WebKit Bug Importer 2021-02-10 14:35:32 PST 
<rdar://problem/74206753>