WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
221520
Differentiate between color spaces used to tag colors and color spaces used to tag destinations
https://bugs.webkit.org/show_bug.cgi?id=221520
Summary
Differentiate between color spaces used to tag colors and color spaces used t...
Sam Weinig
Reported
2021-02-06 10:52:01 PST
Comment hidden (obsolete)
Differentiate between color spaces used to tag colors and color spaces used to tag destinations
Attachments
Patch
(102.40 KB, patch)
2021-02-06 11:03 PST
,
Sam Weinig
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(102.40 KB, patch)
2021-02-06 11:12 PST
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(102.41 KB, patch)
2021-02-06 19:01 PST
,
Sam Weinig
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(103.13 KB, patch)
2021-02-06 19:23 PST
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2021-02-06 10:54:13 PST
These two sets, color tagging (input) and destination tagging (output) have a lot of overlap, it doesn't really make sense for them to use the same enum, as the set we support for one is not the same as the other. Right now, we only ever really use ColorSpace::SRGB and ColorSpace::LinearRGB for destinations, so we should restrict that down.
Sam Weinig
Comment 2
2021-02-06 11:03:37 PST
Comment hidden (obsolete)
Created
attachment 419509
[details]
Patch
Sam Weinig
Comment 3
2021-02-06 11:12:11 PST
Comment hidden (obsolete)
Created
attachment 419511
[details]
Patch
Sam Weinig
Comment 4
2021-02-06 19:01:13 PST
Comment hidden (obsolete)
Created
attachment 419518
[details]
Patch
Sam Weinig
Comment 5
2021-02-06 19:23:27 PST
Created
attachment 419519
[details]
Patch
EWS
Comment 6
2021-02-07 11:27:42 PST
Committed
r272475
: <
https://commits.webkit.org/r272475
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 419519
[details]
.
Radar WebKit Bug Importer
Comment 7
2021-02-10 14:37:13 PST
<
rdar://problem/74206831
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug