WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
22152
Remove asObject() call from JSCallbackObject::getOwnPropertySlot()
https://bugs.webkit.org/show_bug.cgi?id=22152
Summary
Remove asObject() call from JSCallbackObject::getOwnPropertySlot()
Cameron Zwarich (cpst)
Reported
2008-11-09 18:15:13 PST
With the recent change to adopt asType() style cast functions with assertions instead of static_casts in many places, the assertion for the asObject() call in JSCallbackObject::getOwnPropertySlot() has been failing when using any nontrivial client of the JavaScriptCore API. The cast isn't even necessary to call slot.setCustom(), so it should be removed.
Attachments
Proposed patch
(1.65 KB, patch)
2008-11-09 18:21 PST
,
Cameron Zwarich (cpst)
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Cameron Zwarich (cpst)
Comment 1
2008-11-09 18:21:43 PST
Created
attachment 25011
[details]
Proposed patch
Darin Adler
Comment 2
2008-11-10 06:58:29 PST
Comment on
attachment 25011
[details]
Proposed patch r=me
Cameron Zwarich (cpst)
Comment 3
2008-11-10 10:18:04 PST
Landed in
r38265
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug