Bug 22152 - Remove asObject() call from JSCallbackObject::getOwnPropertySlot()
Summary: Remove asObject() call from JSCallbackObject::getOwnPropertySlot()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Cameron Zwarich (cpst)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-09 18:15 PST by Cameron Zwarich (cpst)
Modified: 2008-11-10 10:18 PST (History)
0 users

See Also:


Attachments
Proposed patch (1.65 KB, patch)
2008-11-09 18:21 PST, Cameron Zwarich (cpst)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2008-11-09 18:15:13 PST
With the recent change to adopt asType() style cast functions with assertions instead of static_casts in many places, the assertion for the asObject() call in JSCallbackObject::getOwnPropertySlot() has been failing when using any nontrivial client of the JavaScriptCore API. The cast isn't even necessary to call slot.setCustom(), so it should be removed.
Comment 1 Cameron Zwarich (cpst) 2008-11-09 18:21:43 PST
Created attachment 25011 [details]
Proposed patch
Comment 2 Darin Adler 2008-11-10 06:58:29 PST
Comment on attachment 25011 [details]
Proposed patch

r=me
Comment 3 Cameron Zwarich (cpst) 2008-11-10 10:18:04 PST
Landed in r38265.