Bug 221508 – [Meta][MSVC] Fix warnings

• Status: NEW
• Component: Tools / Tests

[Don Olmstead]

Source/cmake/OptionsMSVC.cmake disables a large number of warnings. Some of these warnings should be fixed and removed from the listing.

[Don Olmstead]

When going through cataloging the ones that looked like they should be fixed were

/wd4060 # switch statement contains no 'case' or 'default' labels
/wd4100 # 'identifier' : unreferenced formal parameter
/wd4127 # conditional expression is constant
/wd4189 # 'identifier' : local variable is initialized but not referenced
/wd4201 # nonstandard extension used : nameless struct/union
/wd4251 # 'identifier' : class 'type' needs to have dll-interface to be used by clients of class 'type2'
/wd4275 # non - DLL-interface class 'class_1' used as base for DLL-interface class 'class_2'
/wd4456 # declaration of 'identifier' hides previous local declaration
/wd4457 # declaration of 'identifier' hides function parameter
/wd4458 # declaration of 'identifier' hides class member
/wd4459 # declaration of 'identifier' hides global declaration
/wd4505 # 'function' : unreferenced local function has been removed
/wd4646 # function declared with __declspec(noreturn) has non-void return type
/wd4701 # Potentially uninitialized local variable 'name' used
/wd4715 # 'function' : not all control paths return a value
/wd4838 # conversion from 'type_1' to 'type_2' requires a narrowing conversion
/wd4840 # non-portable use of class 'type' as an argument to a variadic function
/wd4996 # Your code uses a function, class member, variable, or typedef that's marked deprecated
/wd5205 # delete of an abstract class 'type-name' that has a non-virtual destructor results in undefined behavior

[Radar WebKit Bug Importer]

<rdar://problem/74296664>