Bug 221504 - REGRESSION(r271575) [GStreamer] webrtc/peer-connection-remote-audio-mute2.html is failing
Summary: REGRESSION(r271575) [GStreamer] webrtc/peer-connection-remote-audio-mute2.htm...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-05 14:33 PST by Lauro Moura
Modified: 2021-06-25 01:17 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.45 KB, patch)
2021-06-24 10:13 PDT, Arcady Goldmints-Orlov 		no flags Details | Formatted Diff | Diff
Patch (1.46 KB, patch)
2021-06-24 11:00 PDT, Arcady Goldmints-Orlov 		dpino: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2021-02-05 14:33:43 PST 
webrtc/peer-connection-remote-audio-mute2.html 

r271575 changed MediaStreamTrack to create a new AudioSourceProvider for each node instead of keeping ownership of a single provider and sharing it. Maybe there is some path in gstreamer code that is still assuming the former behavior?

Diff:

--- /home/lauro/dev/WebKit/layout-test-results/webrtc/peer-connection-remote-audio-mute2-expected.txt
+++ /home/lauro/dev/WebKit/layout-test-results/webrtc/peer-connection-remote-audio-mute2-actual.txt
@@ -1,3 +1,3 @@
 
-PASS Muting and unmuting an incoming audio track
+FAIL Muting and unmuting an incoming audio track assert_true: not heard hum from remote disabled track expected true got false
Comment 1 Lauro Moura 2021-02-16 09:31:42 PST 
webrtc/peer-connection-remote-audio-mute.html

This one is also a regression from the same revision, but flaky failing/timing out.
Comment 2 Arcady Goldmints-Orlov 2021-05-25 12:24:42 PDT 
This seems to be fixed as of r277175, I can remove the failure from the TestExpectations.
Comment 3 Arcady Goldmints-Orlov 2021-06-24 10:13:19 PDT 
Created attachment 432183 [details]
Patch
Comment 4 EWS 2021-06-24 10:27:46 PDT 
Downloading mechanize-0.4.5...
Installing mechanize-0.4.5...
Installed mechanize-0.4.5!
/Volumes/Data/worker/Commit-Queue/build/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 5 Arcady Goldmints-Orlov 2021-06-24 11:00:30 PDT 
Created attachment 432192 [details]
Patch
Comment 6 EWS 2021-06-24 11:27:50 PDT 
Committed r279239 (239124@main): <https://commits.webkit.org/239124@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432192 [details].
Comment 7 Radar WebKit Bug Importer 2021-06-24 11:28:25 PDT 
<rdar://problem/79734156>