RESOLVED FIXED 221497
SetIntegrityLevel should call [[DefineOwnProperty]] with partial descriptor
https://bugs.webkit.org/show_bug.cgi?id=221497
Summary SetIntegrityLevel should call [[DefineOwnProperty]] with partial descriptor
Alexey Shvayka
Reported 2021-02-05 12:14:59 PST
SetIntegrityLevel should call [[DefineOwnProperty]] with partial descriptor
Attachments
Patch (4.05 KB, patch)
2021-02-05 13:41 PST, Alexey Shvayka
no flags
Patch (4.57 KB, patch)
2021-02-05 23:22 PST, Alexey Shvayka
ysuzuki: review+
ews-feeder: commit-queue-
Alexey Shvayka
Comment 1 2021-02-05 13:41:59 PST
Alexey Shvayka
Comment 2 2021-02-05 23:22:35 PST
Created attachment 419496 [details] Patch Adjust freeze-invokes-out-of-memory.js stress test.
Yusuke Suzuki
Comment 3 2021-02-07 00:16:01 PST
Comment on attachment 419496 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419496&action=review r=me > JSTests/stress/freeze-invokes-out-of-memory.js:17 > + Object.defineProperty(arguments, '0', {value: s}); 1. Can you rename this filename to define-property-invokes-out-of-memory.js? 2. Can we have a test using freeze onto arguments and ensures OOM is not happening?
Alexey Shvayka
Comment 4 2021-02-11 13:38:13 PST
Alexey Shvayka
Comment 5 2021-02-11 13:39:02 PST
(In reply to Yusuke Suzuki from comment #3) Thank you for review! > 1. Can you rename this filename to define-property-invokes-out-of-memory.js? > 2. Can we have a test using freeze onto arguments and ensures OOM is not > happening? Landed with requested test changes.
Radar WebKit Bug Importer
Comment 6 2021-02-11 13:39:15 PST
Note You need to log in before you can comment on or make changes to this bug.