Bug 221497 - SetIntegrityLevel should call [[DefineOwnProperty]] with partial descriptor
Summary: SetIntegrityLevel should call [[DefineOwnProperty]] with partial descriptor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Minor
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-05 12:14 PST by Alexey Shvayka
Modified: 2021-02-11 13:39 PST (History)
8 users (show)

See Also:

Attachments
Patch (4.05 KB, patch)
2021-02-05 13:41 PST, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Patch (4.57 KB, patch)
2021-02-05 23:22 PST, Alexey Shvayka 		ysuzuki: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2021-02-05 12:14:59 PST 
SetIntegrityLevel should call [[DefineOwnProperty]] with partial descriptor
Comment 1 Alexey Shvayka 2021-02-05 13:41:59 PST 
Created attachment 419456 [details]
Patch
Comment 2 Alexey Shvayka 2021-02-05 23:22:35 PST 
Created attachment 419496 [details]
Patch

Adjust freeze-invokes-out-of-memory.js stress test.
Comment 3 Yusuke Suzuki 2021-02-07 00:16:01 PST 
Comment on attachment 419496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419496&action=review

r=me

> JSTests/stress/freeze-invokes-out-of-memory.js:17
> +    Object.defineProperty(arguments, '0', {value: s});

1. Can you rename this filename to define-property-invokes-out-of-memory.js?
2. Can we have a test using freeze onto arguments and ensures OOM is not happening?
Comment 4 Alexey Shvayka 2021-02-11 13:38:13 PST 
Committed r272747: <https://trac.webkit.org/changeset/272747>
Comment 5 Alexey Shvayka 2021-02-11 13:39:02 PST 
(In reply to Yusuke Suzuki from comment #3)

Thank you for review!

> 1. Can you rename this filename to define-property-invokes-out-of-memory.js?
> 2. Can we have a test using freeze onto arguments and ensures OOM is not
> happening?

Landed with requested test changes.
Comment 6 Radar WebKit Bug Importer 2021-02-11 13:39:15 PST 
<rdar://problem/74249002>