Bug 221466 – Allow sending modifier keys in test_driver.send_keys()

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Manuel Rego Casasnovas]

Created attachment 419407 [details]
Test case

Check the attached example, if you run it as a WPT test:
  Tools/Scripts/run-webkit-tests --gtk LayoutTests/imported/w3c/web-platform-tests/uievents/send-ctrl-key.html

It will fail because it'll get "Unidentified" instead of "Control" in event.key.

[Manuel Rego Casasnovas]

This might be due to the FIXME in: https://webkit-search.igalia.com/webkit/source/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js#157
    // FIXME: Add more cases.
    const SeleniumCharCodeToEventSenderKey = {
        0xE003: 'delete',
        0xE004: '\t',
        0xE00D: ' ',
        0xE012: 'leftArrow',
        0xE013: 'upArrow',
        0xE014: 'rightArrow',
        0xE015: 'downArrow',
    };

Right now it only understands a few char codes.

[Manuel Rego Casasnovas]

Created attachment 419569 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Manuel Rego Casasnovas]

I've to export the WPT test before landing (for some reason the script failed), but I want to check in the bots first here.

[Manuel Rego Casasnovas]

Created attachment 419598 [details]
Patch

[Manuel Rego Casasnovas]

The test has been exported to https://github.com/web-platform-tests/wpt/pull/27526 and passes now in Chromium and Firefox, and also in GTK with this patch.

Probably it's going to fail on Mac so I'd add the proper expectations. Anyway the patch is ready to be reviewed I believe.

[Manuel Rego Casasnovas]

Created attachment 419675 [details]
Patch

[Manuel Rego Casasnovas]

Created attachment 419677 [details]
Patch

[EWS]

Committed r272572: <https://commits.webkit.org/r272572>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419677 [details].

[Radar WebKit Bug Importer]

<rdar://problem/74135384>