Bug 221446 - [GPU Process] Repopulate the TestExpectations file #2
Summary: [GPU Process] Repopulate the TestExpectations file #2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rini Patel
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-04 19:13 PST by Rini Patel
Modified: 2021-02-05 11:57 PST (History)
3 users (show)

See Also:


Attachments
Patch (7.41 KB, patch)
2021-02-04 19:17 PST, Rini Patel
no flags Details | Formatted Diff | Diff
Patch (8.84 KB, patch)
2021-02-05 10:14 PST, Rini Patel
no flags Details | Formatted Diff | Diff
Patch (8.84 KB, patch)
2021-02-05 10:16 PST, Rini Patel
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rini Patel 2021-02-04 19:13:51 PST
Add more media and webrtc failures.
Comment 1 Rini Patel 2021-02-04 19:17:57 PST
Created attachment 419354 [details]
Patch
Comment 2 youenn fablet 2021-02-05 06:01:58 PST
Comment on attachment 419354 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419354&action=review

> LayoutTests/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Since this is gardening, you might be able to mark Unreviewed here.
And ask for cq? instead of r?
Comment 3 EWS 2021-02-05 06:07:17 PST
commit-queue failed to commit attachment 419354 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 4 EWS 2021-02-05 06:14:34 PST
commit-queue failed to commit attachment 419354 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 5 Rini Patel 2021-02-05 10:14:18 PST
Created attachment 419422 [details]
Patch
Comment 6 Rini Patel 2021-02-05 10:16:54 PST
Created attachment 419423 [details]
Patch
Comment 7 Rini Patel 2021-02-05 10:17:31 PST
(In reply to youenn fablet from comment #2)
> Comment on attachment 419354 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=419354&action=review
> 
> > LayoutTests/ChangeLog:6
> > +        Reviewed by NOBODY (OOPS!).
> 
> Since this is gardening, you might be able to mark Unreviewed here.
> And ask for cq? instead of r?

Thanks Youenn, I've rebased the changes.
Comment 8 youenn fablet 2021-02-05 10:20:10 PST
> Thanks Youenn, I've rebased the changes.

Good, let's go.
No need for 'r-' either, just no review flags.
Comment 9 Rini Patel 2021-02-05 10:21:10 PST
(In reply to youenn fablet from comment #8)
> > Thanks Youenn, I've rebased the changes.
> 
> Good, let's go.
> No need for 'r-' either, just no review flags.

Ok, will keep this in mind.
Comment 10 EWS 2021-02-05 10:53:48 PST
Committed r272427: <https://trac.webkit.org/changeset/272427>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419423 [details].
Comment 11 Radar WebKit Bug Importer 2021-02-05 10:54:14 PST
<rdar://problem/74031821>