Bug 221433 - REGRESSION (r272382): 2 webkit.messages_unittest.GeneratedFileContentsTest tests failing after Semaphore.h rename
Summary: REGRESSION (r272382): 2 webkit.messages_unittest.GeneratedFileContentsTest te...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-04 15:53 PST by Ryan Haddad
Modified: 2021-02-04 17:12 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.10 KB, patch)
2021-02-04 16:20 PST, Ross Kirsling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2021-02-04 15:53:35 PST 
[5/1961] webkit.messages_unittest.GeneratedFileContentsTest.test_message_argument_description failed:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/catalina-release-tests-wk2/build/Source/WebKit/Scripts/webkit/messages_unittest.py", line 100, in test_message_argument_description
      self.assertGeneratedFileContentsEqual(implementation_contents, os.path.join(tests_directory, 'MessageArgumentDescriptions.cpp'))
    File "/Volumes/Data/slave/catalina-release-tests-wk2/build/Source/WebKit/Scripts/webkit/messages_unittest.py", line 77, in assertGeneratedFileContentsEqual
      self.assertEquals(actual_line, expected_line_list[index])
  AssertionError: '#include "IPCSemaphore.h"' != '#include "JSIPCBinding.h"'

[12/1961] webkit.messages_unittest.GeneratedFileContentsTest.test_receiver failed:
  Traceback (most recent call last):
    File "/Volumes/Data/slave/catalina-release-tests-wk2/build/Source/WebKit/Scripts/webkit/messages_unittest.py", line 89, in test_receiver
      self.assertGeneratedFileContentsEqual(implementation_contents, os.path.join(tests_directory, '{}MessageReceiver.cpp'.format(receiver_name)))
    File "/Volumes/Data/slave/catalina-release-tests-wk2/build/Source/WebKit/Scripts/webkit/messages_unittest.py", line 77, in assertGeneratedFileContentsEqual
      self.assertEquals(actual_line, expected_line_list[index])
  AssertionError: '#include "IPCSemaphore.h"' != '#include "Semaphore.h"'
Comment 1 Ross Kirsling 2021-02-04 16:05:54 PST 
Great, it's not just arcane but also fragile... 🙄
Comment 2 Ross Kirsling 2021-02-04 16:17:25 PST 
Er wait, no, it looks like the changes to those two files just got dropped from the patch in the process of trying to figure out how the generator script works.
Comment 3 Ross Kirsling 2021-02-04 16:20:16 PST 
Created attachment 419335 [details]
Patch
Comment 4 EWS 2021-02-04 17:11:31 PST 
Committed r272400: <https://trac.webkit.org/changeset/272400>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419335 [details].
Comment 5 Radar WebKit Bug Importer 2021-02-04 17:12:14 PST 
<rdar://problem/74004365>