Bug 221431 – [Mac] Connect MediaSession with MediaRemote and NowPlaying

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Connect MediaSession with MediaRemote and NowPlaying

[Radar WebKit Bug Importer]

<rdar://problem/74000363>

[Eric Carlson]

Created attachment 419333 [details]
Patch

[Eric Carlson]

Created attachment 419338 [details]
Patch

[Eric Carlson]

Created attachment 419344 [details]
Patch

[Eric Carlson]

Created attachment 419345 [details]
Patch

[Eric Carlson]

Created attachment 419347 [details]
Patch

[Eric Carlson]

Created attachment 419388 [details]
Patch

[Eric Carlson]

Created attachment 419392 [details]
Patch

[Eric Carlson]

Created attachment 419429 [details]
Patch

[Jer Noble]

View in context: https://bugs.webkit.org/attachment.cgi?id=419392&action=review

r=me, with just a couple nits.

> Source/WebCore/Modules/mediasession/MediaSession.cpp:54
> +        static const MapEntry entries[] = {

I think this could be `constexpr` rather than just `const`.

> Source/WebCore/Modules/mediasession/MediaSession.cpp:68
> +        HashMap<MediaSessionAction, PlatformMediaSession::RemoteControlCommandType, WTF::IntHash<MediaSessionAction>, WTF::StrongEnumHashTraits<MediaSessionAction>> map;
> +        for (auto& entry : entries)
> +            map.add(entry.action, entry.command);
> +        return map;

I _think_ this whole section could just be written as:

using ActionToCommandMap = HashMap<MediaSessionAction, PlatformMediaSession::RemoteControlCommandType, WTF::IntHash<MediaSessionAction>, WTF::StrongEnumHashTraits<MediaSessionAction>>;
return ActionToCommandMap {
    { MediaSessionAction::Play, PlatformMediaSession::PlayCommand },
...
};

Since HashMap has a constructor that takes an initializer list, but NBD.

> Source/WebCore/platform/mac/RemoteCommandListenerMac.mm:45
> +        static const MapEntry entries[] = {

Same comment about `constexpr` and maybe just using an initializer list here.

[Eric Carlson]

Created attachment 419462 [details]
Patch for landing

[EWS]

Committed r272445: <https://trac.webkit.org/changeset/272445>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419462 [details].

[Eric Carlson]

Reopening to attach new patch.

[Eric Carlson]

Created attachment 419618 [details]
Patch

[EWS]

Committed r272547: <https://commits.webkit.org/r272547>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419618 [details].

[Eric Carlson]

Reopening to attach new patch.

[Eric Carlson]

Created attachment 419657 [details]
Patch

[EWS]

Committed r272563: <https://commits.webkit.org/r272563>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419657 [details].

[Eric Carlson]

Reopening to attach new patch.

[Eric Carlson]

Created attachment 419718 [details]
Patch

[EWS]

/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

[Eric Carlson]

Created attachment 419719 [details]
Patch

[EWS]

commit-queue failed to commit attachment 419719 [details] to WebKit repository. To retry, please set cq+ flag again.

[EWS]

Committed r272589: <https://commits.webkit.org/r272589>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419719 [details].

[Alex Christensen]

r272615