Bug 221425 - RELEASE_ASSERT(bigInt) in VM constructor when constructing a WorkletGlobalScope
Summary: RELEASE_ASSERT(bigInt) in VM constructor when constructing a WorkletGlobalScope
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-04 12:31 PST by Chris Dumez
Modified: 2021-02-04 16:00 PST (History)
9 users (show)

See Also:

Attachments
Patch (14.59 KB, patch)
2021-02-04 12:36 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (13.28 KB, patch)
2021-02-04 12:48 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-02-04 12:31:14 PST 
RELEASE_ASSERT(bigInt) in VM constructor when constructing a WorkletGlobalScope:

Thread 19 Crashed:: WebCore: AudioWorklet
0   com.apple.JavaScriptCore            0x00000007969296f3 WTFCrashWithInfo(int, char const*, char const*, int) + 19 (Assertions.h:671)
1   com.apple.JavaScriptCore            0x0000000796b659e3 JSC::VM::VM(JSC::VM::VMType, JSC::HeapType, WTF::RunLoop*, bool*) + 20387 (VM.cpp:490)
2   com.apple.JavaScriptCore            0x0000000796b693f4 JSC::VM::VM(JSC::VM::VMType, JSC::HeapType, WTF::RunLoop*, bool*) + 19 (VM.cpp:410) [inlined]
3   com.apple.JavaScriptCore            0x0000000796b693f4 JSC::VM::create(JSC::HeapType, WTF::RunLoop*) + 52 (VM.cpp:693)
4   com.apple.WebCore                   0x0000000791dee9f8 WebCore::WorkletGlobalScope::WorkletGlobalScope(WebCore::WorkerOrWorkletThread&, WebCore::WorkletParameters const&) + 40 (WorkletGlobalScope.cpp:53)
5   com.apple.WebCore                   0x0000000790be6902 WebCore::AudioWorkletGlobalScope::AudioWorkletGlobalScope(WebCore::AudioWorkletThread&, WebCore::WorkletParameters const&) + 5 (AudioWorkletGlobalScope.cpp:51) [inlined]
6   com.apple.WebCore                   0x0000000790be6902 WebCore::AudioWorkletGlobalScope::AudioWorkletGlobalScope(WebCore::AudioWorkletThread&, WebCore::WorkletParameters const&) + 18 (AudioWorkletGlobalScope.cpp:53)
7   com.apple.WebCore                   0x0000000790bf29d3 WebCore::AudioWorkletGlobalScope::create(WebCore::AudioWorkletThread&, WebCore::WorkletParameters const&) + 27 (AudioWorkletGlobalScope.h:50) [inlined]
8   com.apple.WebCore                   0x0000000790bf29d3 WebCore::AudioWorkletThread::createGlobalScope() + 51 (AudioWorkletThread.cpp:51)
9   com.apple.WebCore                   0x0000000791d979c9 WebCore::WorkerOrWorkletThread::workerOrWorkletThread() + 57 (WorkerOrWorkletThread.cpp:112)
10  com.apple.JavaScriptCore            0x0000000795d4996c WTF::Function<void ()>::operator()() const + 9 (Function.h:83) [inlined]
11  com.apple.JavaScriptCore            0x0000000795d4996c WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) + 124 (Threading.cpp:181)
12  com.apple.JavaScriptCore            0x0000000795d4bfa9 WTF::wtfThreadEntryPoint(void*) + 9 (ThreadingPOSIX.cpp:241)
13  libsystem_pthread.dylib             0x00007fff203ed954 _pthread_start + 224
14  libsystem_pthread.dylib             0x00007fff203e94a7 thread_start + 15
Comment 1 Chris Dumez 2021-02-04 12:31:24 PST 
<rdar://73747997>
Comment 2 Chris Dumez 2021-02-04 12:36:40 PST 
Created attachment 419311 [details]
Patch
Comment 3 Chris Dumez 2021-02-04 12:48:11 PST 
Created attachment 419313 [details]
Patch
Comment 4 Keith Miller 2021-02-04 15:27:44 PST 
Comment on attachment 419313 [details]
Patch

r=me seems reasonable.
Comment 5 EWS 2021-02-04 15:59:57 PST 
Committed r272393: <https://trac.webkit.org/changeset/272393>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419313 [details].