RESOLVED FIXED 221421
ConsoleMessage: Don't encode string JSONLogValue's as JSON 
https://bugs.webkit.org/show_bug.cgi?id=221421
Summary ConsoleMessage: Don't encode string JSONLogValue's as JSON
Alicia Boya García
Reported 2021-02-04 11:41:10 PST
JSONLogValue's have two tagged types: String and JSON. Despite this, the ConsoleMessage constructor was converting the string values to JSON while coalescing them. This also added quotes on the return value of message() for ConsoleMessage's created with this constructor, but not with others. This patch removes that behavior, keeping strings as strings and using wrapObject() instead of wrapJSONString() for them.
Attachments
Patch (8.01 KB, patch)
2021-02-04 11:46 PST, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
Patch (8.33 KB, patch)
2021-02-05 07:21 PST, Philippe Normand 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (8.64 KB, patch)
2021-02-05 07:42 PST, Philippe Normand 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (8.46 KB, patch)
2021-02-05 08:32 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (10.69 KB, patch)
2021-02-05 09:18 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (11.48 KB, patch)
2021-02-05 13:10 PST, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2021-02-04 11:46:34 PST
Created attachment 419306 [details] Patch
Philippe Normand
Comment 2 2021-02-05 07:21:07 PST
Created attachment 419400 [details] Patch
Philippe Normand
Comment 3 2021-02-05 07:21:54 PST
This is Alicia's patch, I'm only driving-by hoping to fix the wincairo EWS...
Philippe Normand
Comment 4 2021-02-05 07:42:38 PST
Created attachment 419406 [details] Patch
Philippe Normand
Comment 5 2021-02-05 08:32:49 PST
Created attachment 419412 [details] Patch
Philippe Normand
Comment 6 2021-02-05 09:18:16 PST
Created attachment 419416 [details] Patch
Alicia Boya García
Comment 7 2021-02-05 13:10:00 PST
Created attachment 419451 [details] Patch
Alicia Boya García
Comment 8 2021-02-05 13:10:43 PST
Added missing ChangeLog entries.
EWS
Comment 9 2021-02-08 01:47:32 PST
Committed r272484: <https://commits.webkit.org/r272484> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419451 [details].
Radar WebKit Bug Importer
Comment 10 2021-02-10 14:41:52 PST
<rdar://problem/74207049>
Note You need to log in before you can comment on or make changes to this bug.