Bug 221421 - ConsoleMessage: Don't encode string JSONLogValue's as JSON
Summary: ConsoleMessage: Don't encode string JSONLogValue's as JSON
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-04 11:41 PST by Alicia Boya García
Modified: 2021-02-10 14:41 PST (History)
15 users (show)

See Also:

Attachments
Patch (8.01 KB, patch)
2021-02-04 11:46 PST, Alicia Boya García 		no flags Details | Formatted Diff | Diff
Patch (8.33 KB, patch)
2021-02-05 07:21 PST, Philippe Normand 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (8.64 KB, patch)
2021-02-05 07:42 PST, Philippe Normand 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (8.46 KB, patch)
2021-02-05 08:32 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
Patch (10.69 KB, patch)
2021-02-05 09:18 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
Patch (11.48 KB, patch)
2021-02-05 13:10 PST, Alicia Boya García 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2021-02-04 11:41:10 PST 
JSONLogValue's have two tagged types: String and JSON. Despite this,
the ConsoleMessage constructor was converting the string values to
JSON while coalescing them.

This also added quotes on the return value of message() for
ConsoleMessage's created with this constructor, but not with others.

This patch removes that behavior, keeping strings as strings and using
wrapObject() instead of wrapJSONString() for them.
Comment 1 Alicia Boya García 2021-02-04 11:46:34 PST 
Created attachment 419306 [details]
Patch
Comment 2 Philippe Normand 2021-02-05 07:21:07 PST 
Created attachment 419400 [details]
Patch
Comment 3 Philippe Normand 2021-02-05 07:21:54 PST 
This is Alicia's patch, I'm only driving-by hoping to fix the wincairo EWS...
Comment 4 Philippe Normand 2021-02-05 07:42:38 PST 
Created attachment 419406 [details]
Patch
Comment 5 Philippe Normand 2021-02-05 08:32:49 PST 
Created attachment 419412 [details]
Patch
Comment 6 Philippe Normand 2021-02-05 09:18:16 PST 
Created attachment 419416 [details]
Patch
Comment 7 Alicia Boya García 2021-02-05 13:10:00 PST 
Created attachment 419451 [details]
Patch
Comment 8 Alicia Boya García 2021-02-05 13:10:43 PST 
Added missing ChangeLog entries.
Comment 9 EWS 2021-02-08 01:47:32 PST 
Committed r272484: <https://commits.webkit.org/r272484>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419451 [details].
Comment 10 Radar WebKit Bug Importer 2021-02-10 14:41:52 PST 
<rdar://problem/74207049>