RESOLVED FIXED 221415
[Python-3] Change shebang in test-webkitpy 
https://bugs.webkit.org/show_bug.cgi?id=221415
Summary [Python-3] Change shebang in test-webkitpy
Jonathan Bedard
Reported 2021-02-04 09:30:13 PST
test-webkitpy should be Python 3 by default, but we still need a way to invoke Python 2 tests.
Attachments
Patch (2.45 KB, patch)
2021-02-04 10:13 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.45 KB, patch)
2021-02-04 10:14 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (3.55 KB, patch)
2021-02-04 10:48 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-02-04 10:09:54 PST
<rdar://problem/73986503>
Jonathan Bedard
Comment 2 2021-02-04 10:13:48 PST
Created attachment 419294 [details] Patch
Jonathan Bedard
Comment 3 2021-02-04 10:14:57 PST
Created attachment 419295 [details] Patch
Jonathan Bedard
Comment 4 2021-02-04 10:48:31 PST
Created attachment 419300 [details] Patch
Michael Catanzaro
Comment 5 2021-02-04 12:16:46 PST
Comment on attachment 419295 [details] Patch I guess you'll remove this later when able.
Michael Catanzaro
Comment 6 2021-02-04 12:17:17 PST
Comment on attachment 419300 [details] Patch I would probably combine this with the other patch you have in this bug, but whatever.
Jonathan Bedard
Comment 7 2021-02-04 12:41:56 PST
(In reply to Michael Catanzaro from comment #5) > Comment on attachment 419295 [details] > Patch > > I guess you'll remove this later when able. Yes! Much like what we did for Python 3, I think we want to be able to invoke test-webkitpy with Python 2 easily for as long as we're supporting Python 2.
Jonathan Bedard
Comment 8 2021-02-04 12:43:43 PST
(In reply to Michael Catanzaro from comment #6) > Comment on attachment 419300 [details] > Patch > > I would probably combine this with the other patch you have in this bug, but > whatever. I wanted to keep these separate in case we need to revert the one that changes CI's behavior.
EWS
Comment 9 2021-02-04 12:56:13 PST
commit-queue failed to commit attachment 419295 [details] to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 10 2021-02-04 13:22:59 PST
commit-queue failed to commit attachment 419295 [details] to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 11 2021-02-04 13:59:44 PST
Committed r272385: <https://trac.webkit.org/changeset/272385> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419295 [details].
Aakash Jain
Comment 12 2021-02-04 14:21:15 PST
Reopened to land patch 419300.
EWS
Comment 13 2021-02-04 14:33:20 PST
commit-queue failed to commit attachment 419300 [details] to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 14 2021-02-04 15:35:38 PST
commit-queue failed to commit attachment 419300 [details] to WebKit repository. To retry, please set cq+ flag again.
EWS
Comment 15 2021-02-04 16:54:39 PST
Committed r272398: <https://trac.webkit.org/changeset/272398> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419300 [details].
Note You need to log in before you can comment on or make changes to this bug.