Bug 221415 - [Python-3] Change shebang in test-webkitpy
Summary: [Python-3] Change shebang in test-webkitpy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-04 09:30 PST by Jonathan Bedard
Modified: 2021-02-04 16:54 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.45 KB, patch)
2021-02-04 10:13 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (2.45 KB, patch)
2021-02-04 10:14 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (3.55 KB, patch)
2021-02-04 10:48 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-02-04 09:30:13 PST 
test-webkitpy should be Python 3 by default, but we still need a way to invoke Python 2 tests.
Comment 1 Radar WebKit Bug Importer 2021-02-04 10:09:54 PST 
<rdar://problem/73986503>
Comment 2 Jonathan Bedard 2021-02-04 10:13:48 PST 
Created attachment 419294 [details]
Patch
Comment 3 Jonathan Bedard 2021-02-04 10:14:57 PST 
Created attachment 419295 [details]
Patch
Comment 4 Jonathan Bedard 2021-02-04 10:48:31 PST 
Created attachment 419300 [details]
Patch
Comment 5 Michael Catanzaro 2021-02-04 12:16:46 PST 
Comment on attachment 419295 [details]
Patch

I guess you'll remove this later when able.
Comment 6 Michael Catanzaro 2021-02-04 12:17:17 PST 
Comment on attachment 419300 [details]
Patch

I would probably combine this with the other patch you have in this bug, but whatever.
Comment 7 Jonathan Bedard 2021-02-04 12:41:56 PST 
(In reply to Michael Catanzaro from comment #5)
> Comment on attachment 419295 [details]
> Patch
> 
> I guess you'll remove this later when able.

Yes! Much like what we did for Python 3, I think we want to be able to invoke test-webkitpy with Python 2 easily for as long as we're supporting Python 2.
Comment 8 Jonathan Bedard 2021-02-04 12:43:43 PST 
(In reply to Michael Catanzaro from comment #6)
> Comment on attachment 419300 [details]
> Patch
> 
> I would probably combine this with the other patch you have in this bug, but
> whatever.

I wanted to keep these separate in case we need to revert the one that changes CI's behavior.
Comment 9 EWS 2021-02-04 12:56:13 PST 
commit-queue failed to commit attachment 419295 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 10 EWS 2021-02-04 13:22:59 PST 
commit-queue failed to commit attachment 419295 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 11 EWS 2021-02-04 13:59:44 PST 
Committed r272385: <https://trac.webkit.org/changeset/272385>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419295 [details].
Comment 12 Aakash Jain 2021-02-04 14:21:15 PST 
Reopened to land patch 419300.
Comment 13 EWS 2021-02-04 14:33:20 PST 
commit-queue failed to commit attachment 419300 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 14 EWS 2021-02-04 15:35:38 PST 
commit-queue failed to commit attachment 419300 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 15 EWS 2021-02-04 16:54:39 PST 
Committed r272398: <https://trac.webkit.org/changeset/272398>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419300 [details].