Bug 221409 – REGRESSION(r272217): clang warnings in ExtensionsGLOpenGLCommon.h

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Philippe Normand]

In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-29.cpp:3:
In file included from ../../Source/WebCore/platform/graphics/cairo/GraphicsContextGLCairo.cpp:29:
In file included from ../../Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h:48:
../../Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.h:59:10: warning: 'readnPixelsEXT' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
    void readnPixelsEXT(int x, int y, GCGLsizei width, GCGLsizei height, GCGLenum format, GCGLenum type, GCGLsizei bufSize, void *data);
         ^
../../Source/WebCore/platform/graphics/ExtensionsGL.h:304:18: note: overridden virtual function is here
    virtual void readnPixelsEXT(GCGLint x, GCGLint y, GCGLsizei width, GCGLsizei height, GCGLenum format, GCGLenum type, GCGLsizei bufSize, GCGLvoid* data) = 0;
                 ^
In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-29.cpp:3:
In file included from ../../Source/WebCore/platform/graphics/cairo/GraphicsContextGLCairo.cpp:29:
In file included from ../../Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h:48:
../../Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.h:60:10: warning: 'getnUniformfvEXT' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
    void getnUniformfvEXT(GCGLuint program, int location, GCGLsizei bufSize, float *params);
         ^
../../Source/WebCore/platform/graphics/ExtensionsGL.h:305:18: note: overridden virtual function is here
    virtual void getnUniformfvEXT(GCGLuint program, GCGLint location, GCGLsizei bufSize, GCGLfloat* params) = 0;
                 ^
In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-29.cpp:3:
In file included from ../../Source/WebCore/platform/graphics/cairo/GraphicsContextGLCairo.cpp:29:
In file included from ../../Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h:48:
../../Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.h:61:10: warning: 'getnUniformivEXT' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
    void getnUniformivEXT(GCGLuint program, int location, GCGLsizei bufSize, int *params);
         ^
../../Source/WebCore/platform/graphics/ExtensionsGL.h:306:18: note: overridden virtual function is here
    virtual void getnUniformivEXT(GCGLuint program, GCGLint location, GCGLsizei bufSize, GCGLint* params) = 0;
                 ^
3 warnings generated.

[Philippe Normand]

Created attachment 419285 [details]
Patch

[Darin Adler]

Comment on attachment 419285 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419285&action=review

> Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.h:61
> +    void readnPixelsEXT(int x, int y, GCGLsizei width, GCGLsizei height, GCGLenum format, GCGLenum type, GCGLsizei bufSize, void *data) override;
> +    void getnUniformfvEXT(GCGLuint program, int location, GCGLsizei bufSize, float *params) override;
> +    void getnUniformivEXT(GCGLuint program, int location, GCGLsizei bufSize, int *params) override;

If any of these can be final instead, that would be even better.

[EWS]

Committed r272374: <https://trac.webkit.org/changeset/272374>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419285 [details].

[Kimmo Kinnunen]

Thanks for fixing!