RESOLVED FIXED 221406
Some privateClickMeasurement might output the information in different order depending on platform 
https://bugs.webkit.org/show_bug.cgi?id=221406
Summary Some privateClickMeasurement might output the information in different order ...
Carlos Garcia Campos
Reported 2021-02-04 07:58:56 PST
The script conversionReport.php iterates the HTTP headers to show the information, but the headers order can be different for different platforms. We could just check every value we want to show to make sure we always provide them in the same order.
Attachments
Patch (3.04 KB, patch)
2021-02-04 08:01 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (2.88 KB, patch)
2021-02-05 05:14 PST, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2021-02-04 08:01:51 PST
Created attachment 419283 [details] Patch
Kate Cheney
Comment 2 2021-02-04 10:43:05 PST
Comment on attachment 419283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419283&action=review > LayoutTests/ChangeLog:8 > + The script conversionReport.php iterates the HTTP headers to show the information, but the headers order can be nit: header's order > LayoutTests/http/tests/privateClickMeasurement/resources/conversionReport.php:8 > +if (array_key_exists("HTTP_HOST", $httpHeaders)) { Could you do something like “if ($value = $httpHeaders[“HTTP_HOST”]) or will that not work in php? It would turn 2 lines into 1, and only require one lookup. Ditto for all the rest.
Carlos Garcia Campos
Comment 3 2021-02-05 00:15:38 PST
Comment on attachment 419283 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419283&action=review >> LayoutTests/ChangeLog:8 >> + The script conversionReport.php iterates the HTTP headers to show the information, but the headers order can be > > nit: header's order Ok. >> LayoutTests/http/tests/privateClickMeasurement/resources/conversionReport.php:8 >> +if (array_key_exists("HTTP_HOST", $httpHeaders)) { > > Could you do something like “if ($value = $httpHeaders[“HTTP_HOST”]) or will that not work in php? It would turn 2 lines into 1, and only require one lookup. Ditto for all the rest. I don't know php, so I'll just try that
Carlos Garcia Campos
Comment 4 2021-02-05 05:14:18 PST
Created attachment 419393 [details] Patch
Carlos Garcia Campos
Comment 5 2021-02-10 01:42:20 PST
Committed r272642: <https://trac.webkit.org/changeset/272642>
Radar WebKit Bug Importer
Comment 6 2021-02-10 01:43:13 PST
<rdar://problem/74180943>
Note You need to log in before you can comment on or make changes to this bug.