Bug 221401 - Remove GPUProcess flag in MediaRecorder tests
Summary: Remove GPUProcess flag in MediaRecorder tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-04 04:34 PST by youenn fablet
Modified: 2021-02-11 06:40 PST (History)
8 users (show)

See Also:

Attachments
Patch (7.36 KB, patch)
2021-02-04 04:44 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (7.93 KB, patch)
2021-02-04 06:46 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (1.83 KB, patch)
2021-02-11 06:12 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-02-04 04:34:41 PST 
Remove GPUProcess flag in MediaRecorder tests
Comment 1 youenn fablet 2021-02-04 04:44:42 PST 
Created attachment 419273 [details]
Patch
Comment 2 youenn fablet 2021-02-04 06:46:28 PST 
Created attachment 419279 [details]
Patch
Comment 3 youenn fablet 2021-02-05 05:48:30 PST 
ping review
Comment 4 EWS 2021-02-05 10:49:54 PST 
Committed r272426: <https://trac.webkit.org/changeset/272426>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419279 [details].
Comment 5 Radar WebKit Bug Importer 2021-02-05 10:50:15 PST 
<rdar://problem/74031611>
Comment 6 Ryan Haddad 2021-02-09 14:10:53 PST 
This change caused http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html to consistently fail on macOS (See http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html), and appears to have made it flaky on iOS.
Comment 7 Ryan Haddad 2021-02-09 14:13:05 PST 
Reverted r272426 for reason:

Caused test failures / flakiness

Committed r272613: <https://trac.webkit.org/changeset/272613>
Comment 8 youenn fablet 2021-02-11 06:12:00 PST 
Created attachment 419981 [details]
Patch
Comment 9 youenn fablet 2021-02-11 06:13:22 PST 
(In reply to Ryan Haddad from comment #7)
> Reverted r272426 for reason:
> 
> Caused test failures / flakiness
> 
> Committed r272613: <https://trac.webkit.org/changeset/272613>

Relanding part of the change related to http/wpt/mediarecorder/pause-recording.html.
I will wait for the other part of the changes until rdar://problem/74043225 is fixed.
Comment 10 EWS 2021-02-11 06:40:43 PST 
Committed r272722: <https://commits.webkit.org/r272722>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419981 [details].