Bug 221372 - Link libnetworkextension at compile time
Summary: Link libnetworkextension at compile time
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-03 18:20 PST by Kate Cheney
Modified: 2021-02-04 14:25 PST (History)
3 users (show)

See Also:

Attachments
Patch (5.51 KB, patch)
2021-02-04 07:56 PST, Kate Cheney 		no flags Details | Formatted Diff | Diff
Patch (5.54 KB, patch)
2021-02-04 10:16 PST, Kate Cheney 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kate Cheney 2021-02-03 18:20:15 PST 
We should link libnetworkextension to WebKit at compile time so we don't need to soft link it.
Comment 1 Kate Cheney 2021-02-03 18:22:41 PST 
<rdar://problem/73855844>
Comment 2 Kate Cheney 2021-02-04 07:56:01 PST 
Created attachment 419282 [details]
Patch
Comment 3 Brent Fulgham 2021-02-04 09:59:37 PST 
Comment on attachment 419282 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419282&action=review

This is almost correct, but I think it will break Base System in its current form.

> Source/WebKit/Configurations/WebKit.xcconfig:137
> +WK_LIBNETWORKEXTENSION_LDFLAGS_macosx = -lnetworkextension;

In Bug 218314 (r269173) we used "WK_NETWORK_EXTENSION_LD_FLAGS_macosx = -weak_framework NetworkExtension;" because this library is not present in the Base System (recovery mode). I think we need to do the same here.
Comment 4 Kate Cheney 2021-02-04 10:16:05 PST 
Created attachment 419296 [details]
Patch
Comment 5 Brent Fulgham 2021-02-04 13:36:46 PST 
Comment on attachment 419296 [details]
Patch

r=me
Comment 6 EWS 2021-02-04 14:24:14 PST 
Committed r272387: <https://trac.webkit.org/changeset/272387>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419296 [details].
Comment 7 Radar WebKit Bug Importer 2021-02-04 14:25:13 PST 
<rdar://problem/73997366>