WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
221372
Link libnetworkextension at compile time
https://bugs.webkit.org/show_bug.cgi?id=221372
Summary
Link libnetworkextension at compile time
Kate Cheney
Reported
2021-02-03 18:20:15 PST
We should link libnetworkextension to WebKit at compile time so we don't need to soft link it.
Attachments
Patch
(5.51 KB, patch)
2021-02-04 07:56 PST
,
Kate Cheney
no flags
Details
Formatted Diff
Diff
Patch
(5.54 KB, patch)
2021-02-04 10:16 PST
,
Kate Cheney
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Kate Cheney
Comment 1
2021-02-03 18:22:41 PST
<
rdar://problem/73855844
>
Kate Cheney
Comment 2
2021-02-04 07:56:01 PST
Created
attachment 419282
[details]
Patch
Brent Fulgham
Comment 3
2021-02-04 09:59:37 PST
Comment on
attachment 419282
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=419282&action=review
This is almost correct, but I think it will break Base System in its current form.
> Source/WebKit/Configurations/WebKit.xcconfig:137 > +WK_LIBNETWORKEXTENSION_LDFLAGS_macosx = -lnetworkextension;
In
Bug 218314
(
r269173
) we used "WK_NETWORK_EXTENSION_LD_FLAGS_macosx = -weak_framework NetworkExtension;" because this library is not present in the Base System (recovery mode). I think we need to do the same here.
Kate Cheney
Comment 4
2021-02-04 10:16:05 PST
Created
attachment 419296
[details]
Patch
Brent Fulgham
Comment 5
2021-02-04 13:36:46 PST
Comment on
attachment 419296
[details]
Patch r=me
EWS
Comment 6
2021-02-04 14:24:14 PST
Committed
r272387
: <
https://trac.webkit.org/changeset/272387
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 419296
[details]
.
Radar WebKit Bug Importer
Comment 7
2021-02-04 14:25:13 PST
<
rdar://problem/73997366
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug