Bug 221362 - Allow highlight delegate to be set on WKWebView
Summary: Allow highlight delegate to be set on WKWebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-03 15:52 PST by Megan Gardner
Modified: 2021-02-04 14:21 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.87 KB, patch)
2021-02-03 15:53 PST, Megan Gardner
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (1.90 KB, patch)
2021-02-03 16:05 PST, Megan Gardner
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (2.81 KB, patch)
2021-02-03 16:26 PST, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (3.80 KB, patch)
2021-02-04 12:13 PST, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch for landing (3.80 KB, patch)
2021-02-04 13:51 PST, Megan Gardner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2021-02-03 15:52:55 PST
Allow highlight delegate to be set on WKWebView
Comment 1 Megan Gardner 2021-02-03 15:53:43 PST
Created attachment 419199 [details]
Patch
Comment 2 Wenson Hsieh 2021-02-03 16:00:35 PST
Comment on attachment 419199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419199&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:139
> +@protocol _WKAppHighlightDelegate;

Nit - keep these sorted alphabetically?
Comment 3 Megan Gardner 2021-02-03 16:05:47 PST
Created attachment 419200 [details]
Patch
Comment 4 Megan Gardner 2021-02-03 16:26:44 PST
Created attachment 419204 [details]
Patch
Comment 5 Tim Horton 2021-02-03 18:11:16 PST
Comment on attachment 419204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419204&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1417
> +#endif

#else! two returns in a row is bizarre

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:368
> +@property (nonatomic, weak, setter=_setAppHighlightsDelegate:) id <_WKAppHighlightDelegate> _appHighlightsDelegate WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));

is it highlight or highlights? Please decide, now you've got both in one line (and this seems like the opportunity to fix the property name).
Comment 6 Megan Gardner 2021-02-04 12:13:32 PST
Created attachment 419310 [details]
Patch
Comment 7 Megan Gardner 2021-02-04 13:51:50 PST
Created attachment 419317 [details]
Patch for landing
Comment 8 EWS 2021-02-04 14:20:54 PST
Committed r272386: <https://trac.webkit.org/changeset/272386>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419317 [details].
Comment 9 Radar WebKit Bug Importer 2021-02-04 14:21:13 PST
<rdar://problem/73997198>