Bug 22136 - [Gtk] Refactor autoconf/configure.ac in preparation for jsc and webkit build splits
Summary: [Gtk] Refactor autoconf/configure.ac in preparation for jsc and webkit build ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: 19428
  Show dependency treegraph
 
Reported: 2008-11-07 20:46 PST by Jan Alonzo
Modified: 2009-01-31 02:00 PST (History)
0 users

See Also:


Attachments
Refactor and move shareable code in autotools/webkit.m4 (38.01 KB, patch)
2008-11-07 20:52 PST, Jan Alonzo
zimmermann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Alonzo 2008-11-07 20:46:50 PST
Some checks (glib and unicode dependencies) and constructs are actually shareable between JSC and WebKit builds so we need to somehow reuse the same code once we split the JSC and WebKit builds.
Comment 1 Jan Alonzo 2008-11-07 20:52:34 PST
Created attachment 24984 [details]
Refactor and move shareable code in autotools/webkit.m4

1. Create an autotools dir for some autotools-related scripts
2. Move acinclude.m4 amd symbols.filter in autotools/
3. Extract dolt stuff out of acinclude.m4 and put it in autotools/dolt.m4
4. Move shareable code out of configure.ac and into autotools/webkit.m4
Comment 2 Nikolas Zimmermann 2009-01-22 20:31:59 PST
Comment on attachment 24984 [details]
Refactor and move shareable code in autotools/webkit.m4

Looks good to me. In case no builds are broken, r=me.
Comment 3 Jan Alonzo 2009-01-31 01:59:53 PST
Thanks Niko. Landed in r40450.