Bug 221353 - [JSC] Insert PhantomLocal just before SetLocal for |this| to ensure liveness
Summary: [JSC] Insert PhantomLocal just before SetLocal for |this| to ensure liveness
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
: 222152 224354 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-02-03 12:48 PST by Yusuke Suzuki
Modified: 2021-04-10 01:13 PDT (History)
9 users (show)

See Also:

Attachments
Patch (13.79 KB, patch)
2021-02-03 13:02 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (5.38 KB, patch)
2021-02-03 13:30 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (4.50 KB, patch)
2021-02-03 13:32 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-02-03 12:48:58 PST 
[JSC] Update Graph::needsFlushedThis
Comment 1 Yusuke Suzuki 2021-02-03 13:02:06 PST 
Created attachment 419177 [details]
Patch
Comment 2 Yusuke Suzuki 2021-02-03 13:03:44 PST 
<rdar://problem/70373862>
Comment 3 Yusuke Suzuki 2021-02-03 13:30:00 PST 
Discussed with Saam. We should insert PhantomLocal instead to make liveness correct.
Comment 4 Yusuke Suzuki 2021-02-03 13:30:35 PST 
Created attachment 419181 [details]
Patch
Comment 5 Yusuke Suzuki 2021-02-03 13:31:11 PST 
Comment on attachment 419181 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419181&action=review

> Source/JavaScriptCore/dfg/DFGVariableAccessDataDump.cpp:58
> +    } while (index);

This is just for fixing formatting of VariableAccessData. Previously, if index = 0 (|this|), it does not dump unbox info etc.
Comment 6 Yusuke Suzuki 2021-02-03 13:32:02 PST 
Created attachment 419184 [details]
Patch
Comment 7 Saam Barati 2021-02-03 15:22:15 PST 
Comment on attachment 419184 [details]
Patch

Nice. r=me
Comment 8 EWS 2021-02-03 16:10:14 PST 
Committed r272349: <https://trac.webkit.org/changeset/272349>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419184 [details].
Comment 9 Michael Saboff 2021-02-23 15:37:17 PST 
*** Bug 222152 has been marked as a duplicate of this bug. ***
Comment 10 Yusuke Suzuki 2021-04-10 01:13:19 PDT 
*** Bug 224354 has been marked as a duplicate of this bug. ***