RESOLVED FIXED 221325
Make sure GPUProcess MediaRecorder handles correctly muted tracks 
https://bugs.webkit.org/show_bug.cgi?id=221325
Summary Make sure GPUProcess MediaRecorder handles correctly muted tracks
youenn fablet
Reported 2021-02-03 05:19:09 PST
Make sure GPUProcess MediaRecorder handles correctly muted tracks
Attachments
Patch (21.12 KB, patch)
2021-02-03 05:31 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (21.06 KB, patch)
2021-02-03 05:31 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (22.31 KB, patch)
2021-02-03 06:40 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-02-03 05:31:07 PST
Created attachment 419123 [details] Patch
youenn fablet
Comment 2 2021-02-03 05:31:57 PST
Created attachment 419124 [details] Patch
youenn fablet
Comment 3 2021-02-03 06:40:05 PST
Created attachment 419132 [details] Patch
Eric Carlson
Comment 4 2021-02-03 08:39:25 PST
Comment on attachment 419132 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419132&action=review r=me > Source/WebKit/ChangeLog:18 > + * WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp: This isn't new to this patch, but it is really confusing that this Cocoa and GPU Process specific file is called "MediaRecorderPrivate.cpp", especially when we have a platform agnostic file with the same name in WebCore.
youenn fablet
Comment 5 2021-02-03 09:13:55 PST
(In reply to Eric Carlson from comment #4) > Comment on attachment 419132 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=419132&action=review > > r=me > > > Source/WebKit/ChangeLog:18 > > + * WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp: > > This isn't new to this patch, but it is really confusing that this Cocoa and > GPU Process specific file is called "MediaRecorderPrivate.cpp", especially > when we have a platform agnostic file with the same name in WebCore. True, any good name?
youenn fablet
Comment 6 2021-02-03 09:18:04 PST
(In reply to youenn fablet from comment #5) > (In reply to Eric Carlson from comment #4) > > Comment on attachment 419132 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=419132&action=review > > > > r=me > > > > > Source/WebKit/ChangeLog:18 > > > + * WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp: > > > > This isn't new to this patch, but it is really confusing that this Cocoa and > > GPU Process specific file is called "MediaRecorderPrivate.cpp", especially > > when we have a platform agnostic file with the same name in WebCore. > > True, any good name? Discussed offline with Eric, we may go with MediaRecorderPrivateProxy.
EWS
Comment 7 2021-02-03 09:48:14 PST
Committed r272324: <https://trac.webkit.org/changeset/272324> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419132 [details].
Radar WebKit Bug Importer
Comment 8 2021-02-03 09:49:15 PST
<rdar://problem/73936612>
Note You need to log in before you can comment on or make changes to this bug.