Bug 221307 - [macOS] update media controls to use new SF Symbols
Summary: [macOS] update media controls to use new SF Symbols
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-02 17:19 PST by Devin Rousso
Modified: 2021-02-03 14:21 PST (History)
9 users (show)

See Also:

Attachments
[Image] before (inline) (1.08 MB, image/png)
2021-02-02 17:20 PST, Devin Rousso 		no flags Details
[Image] before (fullscreen) (12.42 KB, image/png)
2021-02-02 17:20 PST, Devin Rousso 		no flags Details
Patch (85.97 KB, patch)
2021-02-02 17:22 PST, Devin Rousso 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
[Image] after (inline) (1.04 MB, image/png)
2021-02-02 17:23 PST, Devin Rousso 		no flags Details
[Image] after (fullscreen) (15.53 KB, image/png)
2021-02-02 17:23 PST, Devin Rousso 		no flags Details
Patch (113.83 KB, patch)
2021-02-02 21:03 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (91.66 KB, patch)
2021-02-03 11:51 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
[Image] after (inline) (1.04 MB, image/png)
2021-02-03 11:51 PST, Devin Rousso 		no flags Details
[Image] after (fullscreen) (15.22 KB, image/png)
2021-02-03 11:51 PST, Devin Rousso 		no flags Details
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-02-02 17:19:39 PST 
.
Comment 1 Devin Rousso 2021-02-02 17:20:06 PST 
Created attachment 419082 [details]
[Image] before (inline)
Comment 2 Devin Rousso 2021-02-02 17:20:18 PST 
Created attachment 419083 [details]
[Image] before (fullscreen)
Comment 3 Devin Rousso 2021-02-02 17:22:47 PST 
Created attachment 419084 [details]
Patch
Comment 4 Devin Rousso 2021-02-02 17:23:05 PST 
Created attachment 419085 [details]
[Image] after (inline)
Comment 5 Devin Rousso 2021-02-02 17:23:16 PST 
Created attachment 419086 [details]
[Image] after (fullscreen)
Comment 6 Devin Rousso 2021-02-02 21:03:12 PST 
Created attachment 419100 [details]
Patch
Comment 7 Eric Carlson 2021-02-03 08:19:08 PST 
Comment on attachment 419100 [details]
Patch

r=me once the bots are happy
Comment 8 Devin Rousso 2021-02-03 11:51:09 PST 
Created attachment 419163 [details]
Patch

regenerated icons to be centered and to not adjust the width for non-fullscreen
Comment 9 Devin Rousso 2021-02-03 11:51:27 PST 
Created attachment 419164 [details]
[Image] after (inline)
Comment 10 Devin Rousso 2021-02-03 11:51:41 PST 
Created attachment 419165 [details]
[Image] after (fullscreen)
Comment 11 EWS 2021-02-03 14:20:54 PST 
Committed r272339: <https://trac.webkit.org/changeset/272339>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419163 [details].
Comment 12 Radar WebKit Bug Importer 2021-02-03 14:21:15 PST 
<rdar://problem/73949557>