Bug 221305 – [GPUProcess][iOS] Audio is lost after media playback recovers from the GPUProcess crash

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Chris Dumez]

Audio is lost after media playback recovers from the GPUProcess crash (on iOS Only).

[Radar WebKit Bug Importer]

<rdar://problem/73904864>

[Chris Dumez]

Created attachment 419293 [details]
WIP Patch

[Chris Dumez]

Created attachment 419297 [details]
Patch

[Peng Liu]

Comment on attachment 419297 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419297&action=review

> Source/WebCore/ChangeLog:9
> +        The issue was that when the GPUProcess crashed while in the middle on media playback, we would

Nit. s/on media playback/of media playback/

> Source/WebKit/ChangeLog:9
> +        Fix issue where we would sometimes loose the video after recovering from a GPUProcess

Nit. s/loose/lose/

> Source/WebCore/platform/graphics/MediaPlayer.h:-221
> -    virtual void mediaPlayerExitFullscreen() { }

I am surprised that those two functions are not used. But bots seem to be happy with the removal. :-)

[Chris Dumez]

Created attachment 419314 [details]
Patch

[EWS]

Committed r272414: <https://trac.webkit.org/changeset/272414>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419314 [details].