RESOLVED FIXED 221267
WebXRSystem::RequestSession with 'viewer' as a required feature should succeed 
https://bugs.webkit.org/show_bug.cgi?id=221267
Summary WebXRSystem::RequestSession with 'viewer' as a required feature should succeed
Imanol Fernandez
Reported 2021-02-02 09:27:57 PST
WebXRSystem::RequestSession with 'viewer' as a required feature should succeed, even without user activation.
Attachments
Patch (5.61 KB, patch)
2021-02-02 09:56 PST, Imanol Fernandez 		svillar: review+
DetailsFormatted DiffDiff
Patch for landing (5.65 KB, patch)
2021-02-08 07:44 PST, Imanol Fernandez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Imanol Fernandez
Comment 1 2021-02-02 09:56:32 PST
Created attachment 419017 [details] Patch
Sergio Villar Senin
Comment 2 2021-02-08 07:22:09 PST
Comment on attachment 419017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419017&action=review > Source/WebCore/Modules/webxr/WebXRSystem.cpp:211 > + auto feature = parseEnumeration<XRReferenceSpaceType>(*globalObject.document()->globalObject(), features.first()); I guess you can directly use the document parameter instead of retrieving it from the DOMWindow. > LayoutTests/ChangeLog:8 > + * platform/wpe/TestExpectations: Nit: just add something like "marked a test as passing" or something like that.
Imanol Fernandez
Comment 3 2021-02-08 07:44:28 PST
Created attachment 419591 [details] Patch for landing
EWS
Comment 4 2021-02-08 08:17:08 PST
Committed r272492: <https://commits.webkit.org/r272492> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419591 [details].
Radar WebKit Bug Importer
Comment 5 2021-02-10 14:43:50 PST
<rdar://problem/74207130>
Note You need to log in before you can comment on or make changes to this bug.