WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
221250
WKASCAuthorizationPresenterDelegate needs to import RunLoop.h and BlockPtr.h
https://bugs.webkit.org/show_bug.cgi?id=221250
Summary
WKASCAuthorizationPresenterDelegate needs to import RunLoop.h and BlockPtr.h
Antoine Quint
Reported
2021-02-02 01:02:40 PST
WKASCAuthorizationPresenterDelegate needs to import RunLoop.h and BlockPtr.h
Attachments
Patch
(1.34 KB, patch)
2021-02-02 01:03 PST
,
Antoine Quint
koivisto
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Antoine Quint
Comment 1
2021-02-02 01:03:13 PST
Created
attachment 418971
[details]
Patch
Antti Koivisto
Comment 2
2021-02-02 02:22:27 PST
Comment on
attachment 418971
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=418971&action=review
> Source/WebKit/UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.mm:35 > +#import <wtf/BlockPtr.h> > +#import <wtf/RunLoop.h> > #import "AuthenticationServicesCoreSoftLink.h"
Don't we usually sort wtf includes last? Wonder why style bot is not complaining.
Antoine Quint
Comment 3
2021-02-02 02:24:31 PST
(In reply to Antti Koivisto from
comment #2
)
> Comment on
attachment 418971
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=418971&action=review
> > > Source/WebKit/UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.mm:35 > > +#import <wtf/BlockPtr.h> > > +#import <wtf/RunLoop.h> > > #import "AuthenticationServicesCoreSoftLink.h" > > Don't we usually sort wtf includes last? Wonder why style bot is not > complaining.
Actually, the style checker complained the other way around that soft-linking headers should appear last.
Dean Jackson
Comment 4
2021-02-02 02:27:44 PST
Comment on
attachment 418971
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=418971&action=review
>>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.mm:35 >>> #import "AuthenticationServicesCoreSoftLink.h" >> >> Don't we usually sort wtf includes last? Wonder why style bot is not complaining. > > Actually, the style checker complained the other way around that soft-linking headers should appear last.
Huh!? If that's the case, I think there should be a blank line separating them.
Antoine Quint
Comment 5
2021-02-02 02:48:05 PST
(In reply to Dean Jackson from
comment #4
)
> Comment on
attachment 418971
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=418971&action=review
> > >>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.mm:35 > >>> #import "AuthenticationServicesCoreSoftLink.h" > >> > >> Don't we usually sort wtf includes last? Wonder why style bot is not complaining. > > > > Actually, the style checker complained the other way around that soft-linking headers should appear last. > > Huh!?
Yeah!
> If that's the case, I think there should be a blank line separating them.
Sure, will do that.
Antoine Quint
Comment 6
2021-02-02 03:07:35 PST
Committed
r272203
: <
https://trac.webkit.org/changeset/272203
>
Radar WebKit Bug Importer
Comment 7
2021-02-02 03:08:13 PST
<
rdar://problem/73872818
>
Jiewen Tan
Comment 8
2021-02-02 10:15:44 PST
Thanks for fixing this issue. Sorry for causing it.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug