Bug 221250 - WKASCAuthorizationPresenterDelegate needs to import RunLoop.h and BlockPtr.h
Summary: WKASCAuthorizationPresenterDelegate needs to import RunLoop.h and BlockPtr.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-02 01:02 PST by Antoine Quint
Modified: 2021-02-02 10:15 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.34 KB, patch)
2021-02-02 01:03 PST, Antoine Quint
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2021-02-02 01:02:40 PST
WKASCAuthorizationPresenterDelegate needs to import RunLoop.h and BlockPtr.h
Comment 1 Antoine Quint 2021-02-02 01:03:13 PST
Created attachment 418971 [details]
Patch
Comment 2 Antti Koivisto 2021-02-02 02:22:27 PST
Comment on attachment 418971 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418971&action=review

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.mm:35
> +#import <wtf/BlockPtr.h>
> +#import <wtf/RunLoop.h>
>  #import "AuthenticationServicesCoreSoftLink.h"

Don't we usually sort wtf includes last? Wonder why style bot is not complaining.
Comment 3 Antoine Quint 2021-02-02 02:24:31 PST
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 418971 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=418971&action=review
> 
> > Source/WebKit/UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.mm:35
> > +#import <wtf/BlockPtr.h>
> > +#import <wtf/RunLoop.h>
> >  #import "AuthenticationServicesCoreSoftLink.h"
> 
> Don't we usually sort wtf includes last? Wonder why style bot is not
> complaining.

Actually, the style checker complained the other way around that soft-linking headers should appear last.
Comment 4 Dean Jackson 2021-02-02 02:27:44 PST
Comment on attachment 418971 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418971&action=review

>>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.mm:35
>>>  #import "AuthenticationServicesCoreSoftLink.h"
>> 
>> Don't we usually sort wtf includes last? Wonder why style bot is not complaining.
> 
> Actually, the style checker complained the other way around that soft-linking headers should appear last.

Huh!? If that's the case, I think there should be a blank line separating them.
Comment 5 Antoine Quint 2021-02-02 02:48:05 PST
(In reply to Dean Jackson from comment #4)
> Comment on attachment 418971 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=418971&action=review
> 
> >>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.mm:35
> >>>  #import "AuthenticationServicesCoreSoftLink.h"
> >> 
> >> Don't we usually sort wtf includes last? Wonder why style bot is not complaining.
> > 
> > Actually, the style checker complained the other way around that soft-linking headers should appear last.
> 
> Huh!?

Yeah!

> If that's the case, I think there should be a blank line separating them.

Sure, will do that.
Comment 6 Antoine Quint 2021-02-02 03:07:35 PST
Committed r272203: <https://trac.webkit.org/changeset/272203>
Comment 7 Radar WebKit Bug Importer 2021-02-02 03:08:13 PST
<rdar://problem/73872818>
Comment 8 Jiewen Tan 2021-02-02 10:15:44 PST
Thanks for fixing this issue. Sorry for causing it.