WKASCAuthorizationPresenterDelegate needs to import RunLoop.h and BlockPtr.h
Created attachment 418971 [details] Patch
Comment on attachment 418971 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418971&action=review > Source/WebKit/UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.mm:35 > +#import <wtf/BlockPtr.h> > +#import <wtf/RunLoop.h> > #import "AuthenticationServicesCoreSoftLink.h" Don't we usually sort wtf includes last? Wonder why style bot is not complaining.
(In reply to Antti Koivisto from comment #2) > Comment on attachment 418971 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418971&action=review > > > Source/WebKit/UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.mm:35 > > +#import <wtf/BlockPtr.h> > > +#import <wtf/RunLoop.h> > > #import "AuthenticationServicesCoreSoftLink.h" > > Don't we usually sort wtf includes last? Wonder why style bot is not > complaining. Actually, the style checker complained the other way around that soft-linking headers should appear last.
Comment on attachment 418971 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418971&action=review >>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.mm:35 >>> #import "AuthenticationServicesCoreSoftLink.h" >> >> Don't we usually sort wtf includes last? Wonder why style bot is not complaining. > > Actually, the style checker complained the other way around that soft-linking headers should appear last. Huh!? If that's the case, I think there should be a blank line separating them.
(In reply to Dean Jackson from comment #4) > Comment on attachment 418971 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418971&action=review > > >>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.mm:35 > >>> #import "AuthenticationServicesCoreSoftLink.h" > >> > >> Don't we usually sort wtf includes last? Wonder why style bot is not complaining. > > > > Actually, the style checker complained the other way around that soft-linking headers should appear last. > > Huh!? Yeah! > If that's the case, I think there should be a blank line separating them. Sure, will do that.
Committed r272203: <https://trac.webkit.org/changeset/272203>
<rdar://problem/73872818>
Thanks for fixing this issue. Sorry for causing it.