Bug 221238 - Completion value of a finally block should not be ignored if completion is abrupt
Summary: Completion value of a finally block should not be ignored if completion is ab...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-01 18:12 PST by Ross Kirsling
Modified: 2021-02-02 15:25 PST (History)
8 users (show)

See Also:

Attachments
Patch (6.45 KB, patch)
2021-02-01 18:23 PST, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch (11.04 KB, patch)
2021-02-01 19:12 PST, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch (11.09 KB, patch)
2021-02-01 19:20 PST, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch for landing (10.83 KB, patch)
2021-02-02 12:22 PST, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2021-02-01 18:12:02 PST 
Completion value of a finally block should not be ignored if completion is nabrupt
Comment 1 Ross Kirsling 2021-02-01 18:23:31 PST 
Created attachment 418950 [details]
Patch
Comment 2 Ross Kirsling 2021-02-01 19:12:17 PST 
Created attachment 418952 [details]
Patch
Comment 3 Ross Kirsling 2021-02-01 19:20:46 PST 
Created attachment 418953 [details]
Patch
Comment 4 Yusuke Suzuki 2021-02-02 12:16:32 PST 
Comment on attachment 418953 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418953&action=review

r=me

> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:4560
> +            int finallyStartOffset = m_catchBlock ? m_catchBlock->endOffset() + 1 : m_tryBlock->endOffset() + 1;

Let's put this before this if-else.
Comment 5 Ross Kirsling 2021-02-02 12:22:19 PST 
Created attachment 419047 [details]
Patch for landing
Comment 6 EWS 2021-02-02 15:24:53 PST 
Committed r272243: <https://trac.webkit.org/changeset/272243>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419047 [details].
Comment 7 Radar WebKit Bug Importer 2021-02-02 15:25:14 PST 
<rdar://problem/73901838>