RESOLVED FIXED 221235
ews isn't retrying builds when kill-old-processes fails 
https://bugs.webkit.org/show_bug.cgi?id=221235
Summary ews isn't retrying builds when kill-old-processes fails
Aakash Jain
Reported 2021-02-01 17:28:40 PST
ews isn't retrying builds when kill old process fails. e.g.: https://ews-build.webkit.org/#/builders/56/builds/196 didn't resulted in retry. Retry on kill-old-process failure was added in https://trac.webkit.org/changeset/252324/webkit which was working fine. But seems like https://trac.webkit.org/r257654 broke it.
Attachments
Patch (3.33 KB, patch)
2021-02-01 17:31 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2021-02-01 17:31:52 PST
Created attachment 418944 [details] Patch
Aakash Jain
Comment 2 2021-02-02 02:37:13 PST
Sample run: https://ews-build.webkit-uat.org/#/builders/13/builds/3883
EWS
Comment 3 2021-02-02 03:12:21 PST
Committed r272204: <https://trac.webkit.org/changeset/272204> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418944 [details].
Radar WebKit Bug Importer
Comment 4 2021-02-02 03:13:13 PST
<rdar://problem/73872929>
Aakash Jain
Comment 5 2021-02-22 07:23:52 PST
This seems to work fine. For e.g: https://ews-build.webkit.org/#/builders/58/builds/2278 was retried when kill-old-processes failed (as bot was in bad state).
Note You need to log in before you can comment on or make changes to this bug.