Bug 221200 - Only update IPC connection of RemoteCaptureSampleManager for audio sources
Summary: Only update IPC connection of RemoteCaptureSampleManager for audio sources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-01 05:17 PST by youenn fablet
Modified: 2021-02-02 04:13 PST (History)
8 users (show)

See Also:

Attachments
Patch (1.59 KB, patch)
2021-02-01 05:18 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (2.79 KB, patch)
2021-02-02 02:06 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-02-01 05:17:24 PST 
Only update IPC connection of RemoteCaptureSampleManager for audio sources
Comment 1 youenn fablet 2021-02-01 05:18:49 PST 
Created attachment 418861 [details]
Patch
Comment 2 Eric Carlson 2021-02-01 09:13:08 PST 
Comment on attachment 418861 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418861&action=review

> Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:201
>  void UserMediaCaptureManager::didUpdateSourceConnection(RemoteRealtimeMediaSource& source)
>  {
> -    m_remoteCaptureSampleManager.didUpdateSourceConnection(source);
> +    if (source.type() == RealtimeMediaSource::Type::Audio)
> +        m_remoteCaptureSampleManager.didUpdateSourceConnection(source);
>  }

It isn't clear why this should be for audio only. Should the method be renamed, or at least add a comment explaining why this is?
Comment 3 youenn fablet 2021-02-02 02:03:33 PST 
Comment on attachment 418861 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418861&action=review

>> Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:201
>>  }
> 
> It isn't clear why this should be for audio only. Should the method be renamed, or at least add a comment explaining why this is?

Right, let's rename m_remoteCaptureSampleManager to m_remoteAudioCaptureSampleManager.
Comment 4 youenn fablet 2021-02-02 02:06:01 PST 
Created attachment 418974 [details]
Patch for landing
Comment 5 EWS 2021-02-02 02:56:23 PST 
commit-queue failed to commit attachment 418974 [details] to WebKit repository.
Comment 6 EWS 2021-02-02 03:12:02 PST 
commit-queue failed to commit attachment 418974 [details] to WebKit repository.
Comment 7 EWS 2021-02-02 04:12:10 PST 
Committed r272205: <https://trac.webkit.org/changeset/272205>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418974 [details].
Comment 8 Radar WebKit Bug Importer 2021-02-02 04:13:13 PST 
<rdar://problem/73874360>