Bug 221200 – Only update IPC connection of RemoteCaptureSampleManager for audio sources

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Only update IPC connection of RemoteCaptureSampleManager for audio sources

[youenn fablet]

Created attachment 418861 [details]
Patch

[Eric Carlson]

Comment on attachment 418861 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418861&action=review

> Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:201
>  void UserMediaCaptureManager::didUpdateSourceConnection(RemoteRealtimeMediaSource& source)
>  {
> -    m_remoteCaptureSampleManager.didUpdateSourceConnection(source);
> +    if (source.type() == RealtimeMediaSource::Type::Audio)
> +        m_remoteCaptureSampleManager.didUpdateSourceConnection(source);
>  }

It isn't clear why this should be for audio only. Should the method be renamed, or at least add a comment explaining why this is?

[youenn fablet]

Comment on attachment 418861 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418861&action=review

>> Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:201
>>  }
> 
> It isn't clear why this should be for audio only. Should the method be renamed, or at least add a comment explaining why this is?

Right, let's rename m_remoteCaptureSampleManager to m_remoteAudioCaptureSampleManager.

[youenn fablet]

Created attachment 418974 [details]
Patch for landing

[EWS]

commit-queue failed to commit attachment 418974 [details] to WebKit repository.

[EWS]

commit-queue failed to commit attachment 418974 [details] to WebKit repository.

[EWS]

Committed r272205: <https://trac.webkit.org/changeset/272205>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418974 [details].

[Radar WebKit Bug Importer]

<rdar://problem/73874360>