Bug 221179 - [LFC][IFC] Line gap metric should apply to all inline boxes
Summary: [LFC][IFC] Line gap metric should apply to all inline boxes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-30 10:09 PST by zalan
Modified: 2021-01-30 11:35 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.74 KB, patch)
2021-01-30 10:16 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-01-30 10:09:50 PST 
"If line-height computes to normal and either text-edge is leading or this is the root inline box, the font’s line gap metric may also be incorporated into A and D by adding half to each side as half-leading." https://www.w3.org/TR/css-inline-3/#inline-height
since we don't have text-edge support yet, it applies to all inline boxes.
Comment 1 zalan 2021-01-30 10:16:16 PST 
Created attachment 418817 [details]
Patch
Comment 2 EWS 2021-01-30 11:34:53 PST 
Committed r272118: <https://trac.webkit.org/changeset/272118>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418817 [details].
Comment 3 Radar WebKit Bug Importer 2021-01-30 11:35:14 PST 
<rdar://problem/73794661>