Bug 221164 - Update consumeNumberRaw() to return an Optional<double> rather than using a bool/out parameter pattern
Summary: Update consumeNumberRaw() to return an Optional<double> rather than using a b...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-29 16:11 PST by Sam Weinig
Modified: 2021-01-29 20:14 PST (History)
8 users (show)

See Also:


Attachments
Patch (26.47 KB, patch)
2021-01-29 16:12 PST, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2021-01-29 16:11:15 PST
Update consumeNumberRaw() to return an Optional<double> rather than using a bool/out parameter pattern
Comment 1 Sam Weinig 2021-01-29 16:12:18 PST
Created attachment 418783 [details]
Patch
Comment 2 Darin Adler 2021-01-29 17:09:15 PST
Comment on attachment 418783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418783&action=review

Seems like a helper that does a number or a percentage and converts the percentage just by dividing by 100 would simplify code in a few different places.

> Source/WebCore/css/parser/CSSPropertyParser.cpp:5038
> +            if (auto num = consumeNumberRaw(m_range)) {

Could have expanded the name num to number since touching this code.

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:780
> +            alpha = clampTo<double>(*percent / 100.0f, 0.0, 1.0);

The "f" here seems wrong. Was in the old code too, but wrong.
Comment 3 Sam Weinig 2021-01-29 17:45:20 PST
Comment on attachment 418783 [details]
Patch

Will address feedback in follow up already in the pipeline.
Comment 4 EWS 2021-01-29 18:13:51 PST
Committed r272094: <https://trac.webkit.org/changeset/272094>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418783 [details].
Comment 5 Radar WebKit Bug Importer 2021-01-29 18:14:13 PST
<rdar://problem/73780435>
Comment 6 Sam Weinig 2021-01-29 20:14:05 PST
(In reply to Sam Weinig from comment #3)
> Comment on attachment 418783 [details]
> Patch
> 
> Will address feedback in follow up already in the pipeline.

Specifically, they are addressed by https://bugs.webkit.org/show_bug.cgi?id=221174.