Bug 221164 – Update consumeNumberRaw() to return an Optional<double> rather than using a bool/out parameter pattern

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Update consumeNumberRaw() to return an Optional<double> rather than using a bool/out parameter pattern

[Sam Weinig]

Created attachment 418783 [details]
Patch

[Darin Adler]

Comment on attachment 418783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418783&action=review

Seems like a helper that does a number or a percentage and converts the percentage just by dividing by 100 would simplify code in a few different places.

> Source/WebCore/css/parser/CSSPropertyParser.cpp:5038
> +            if (auto num = consumeNumberRaw(m_range)) {

Could have expanded the name num to number since touching this code.

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:780
> +            alpha = clampTo<double>(*percent / 100.0f, 0.0, 1.0);

The "f" here seems wrong. Was in the old code too, but wrong.

[Sam Weinig]

Comment on attachment 418783 [details]
Patch

Will address feedback in follow up already in the pipeline.

[EWS]

Committed r272094: <https://trac.webkit.org/changeset/272094>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418783 [details].

[Radar WebKit Bug Importer]

<rdar://problem/73780435>

[Sam Weinig]

(In reply to Sam Weinig from comment #3)
> Comment on attachment 418783 [details]
> Patch
> 
> Will address feedback in follow up already in the pipeline.

Specifically, they are addressed by https://bugs.webkit.org/show_bug.cgi?id=221174.