Bug 221162 - autoinstall.py: Don't use an XML parser to parse HTML, fixes "mismatched tag" error
Summary: autoinstall.py: Don't use an XML parser to parse HTML, fixes "mismatched tag"...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
URL:
Keywords: InRadar
: 221361 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-01-29 16:06 PST by Alicia Boya García
Modified: 2021-02-03 15:34 PST (History)
3 users (show)

See Also:


Attachments
Patch (5.62 KB, patch)
2021-01-29 16:08 PST, Alicia Boya García
no flags Details | Formatted Diff | Diff
Patch (5.95 KB, patch)
2021-01-29 16:21 PST, Alicia Boya García
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2021-01-29 16:06:57 PST
Today autoinstall.py started failing becagse the page returned by
https://pypi.org/simple/fasteners/ now contains a <meta> tag, which is
not parseable as XML without the trailing slash.

This patch replaces that code to use an HTML parser instead of an XML
parser.
Comment 1 Alicia Boya García 2021-01-29 16:08:20 PST
Created attachment 418781 [details]
Patch
Comment 2 Alicia Boya García 2021-01-29 16:21:02 PST
Created attachment 418784 [details]
Patch
Comment 3 Jonathan Bedard 2021-01-29 16:44:41 PST
Alicia is right about this fix, although I'm reluctant to land something like this Friday afternoon given how much infrastructure we have relying on it. Since things are stable right now, I'll take a close look Monday morning.
Comment 4 EWS 2021-02-01 11:51:25 PST
commit-queue failed to commit attachment 418784 [details] to WebKit repository.
Comment 5 Jonathan Bedard 2021-02-01 11:55:34 PST
(In reply to EWS from comment #4)
> commit-queue failed to commit attachment 418784 [details] to WebKit
> repository.

Aakash and I are in discussion about this commit-queue issue now.
Comment 6 EWS 2021-02-01 12:37:50 PST
Committed r272167: <https://trac.webkit.org/changeset/272167>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418784 [details].
Comment 7 Radar WebKit Bug Importer 2021-02-01 12:38:14 PST
<rdar://problem/73841294>
Comment 8 Jonathan Bedard 2021-02-03 15:34:16 PST
*** Bug 221361 has been marked as a duplicate of this bug. ***