Bug 221156 – [macOS] Remove support for image controls

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Wenson Hsieh]

Remove support for image controls

[Wenson Hsieh]

Created attachment 418780 [details]
For EWS

[Tim Horton]

Comment on attachment 418780 [details]
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=418780&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:100
> -@property (nonatomic, setter=_setImageControlsEnabled:) BOOL _imageControlsEnabled WK_API_AVAILABLE(macos(10.12));
> +@property (nonatomic, setter=_setImageControlsEnabled:) BOOL _imageControlsEnabled WK_API_DEPRECATED("Image controls are no longer supported", macos(10.12, WK_MAC_TBA));

Don't we have pretty strong evidence that we can just delete this?

[Wenson Hsieh]

Comment on attachment 418780 [details]
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=418780&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:100
>> +@property (nonatomic, setter=_setImageControlsEnabled:) BOOL _imageControlsEnabled WK_API_DEPRECATED("Image controls are no longer supported", macos(10.12, WK_MAC_TBA));
> 
> Don't we have pretty strong evidence that we can just delete this?

Ah, so after some more digging, it looks like Mail actually turns on this SPI for some of their web views, but then never attempts to set the corresponding attribute (x-webkit-imagemenu) on any image elements. When using web inspector to manually add the attribute, I'm able to get a button to show up when hovering over images, but it doesn't have any effect.

As such, it seems that use of this SPI by Mail was unintentional, so while we can't remove the SPI quite yet, marking it as deprecated is probably a good first step.

[Wenson Hsieh]

Created attachment 418803 [details]
Patch

[EWS]

commit-queue failed to commit attachment 418803 [details] to WebKit repository.

[Wenson Hsieh]

Created attachment 418815 [details]
Patch for landing

[EWS]

Committed r272117: <https://trac.webkit.org/changeset/272117>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418815 [details].

[Radar WebKit Bug Importer]

<rdar://problem/73794193>