Bug 221150 - [webkitcorepy] Support machines without Unix signal handling
Summary: [webkitcorepy] Support machines without Unix signal handling
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
Keywords: InRadar
Depends on:
Reported: 2021-01-29 13:34 PST by Jonathan Bedard
Modified: 2021-02-01 12:56 PST (History)
3 users (show)

See Also:

Patch (6.51 KB, patch)
2021-01-29 13:41 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (9.10 KB, patch)
2021-01-29 17:00 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (9.13 KB, patch)
2021-02-01 10:42 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-01-29 13:34:18 PST
Not all machines support signal.alarm. Our timeout code makes an effort to function without signal.alarm when possible. Timeout is much less robust without signal.alarm, but is still useful in many circumstances.
Comment 1 Radar WebKit Bug Importer 2021-01-29 13:34:30 PST
Comment 2 Jonathan Bedard 2021-01-29 13:41:04 PST
Created attachment 418766 [details]
Comment 3 Don Olmstead 2021-01-29 15:19:59 PST
Works for me locally with Python 3 on Windows!

There are other cases where signal.SIGKILL is used which isn't present in Python for Windows so some more cross platform fixes should probably happen around usage of signal.
Comment 4 Jonathan Bedard 2021-01-29 16:48:28 PST
Looks like there are a few in task_pool.py and our mock popen code. We might also need to address this in webkitpy/common/interrupt_debugging.py, but that would have broken layout tests in Python 2 on Windows machines as well.
Comment 5 Jonathan Bedard 2021-01-29 17:00:15 PST
Created attachment 418788 [details]
Comment 6 Aakash Jain 2021-02-01 10:01:04 PST
Comment 7 Jonathan Bedard 2021-02-01 10:42:08 PST
Created attachment 418896 [details]
Patch for landing
Comment 8 EWS 2021-02-01 12:56:45 PST
Committed r272169: <https://trac.webkit.org/changeset/272169>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418896 [details].