Bug 221149 - SourceParseMode should be a member of the JSC::Parser
Summary: SourceParseMode should be a member of the JSC::Parser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-29 12:57 PST by Keith Miller
Modified: 2021-01-29 16:37 PST (History)
7 users (show)

See Also:

Attachments
Patch (43.97 KB, patch)
2021-01-29 12:59 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (44.10 KB, patch)
2021-01-29 14:15 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (44.10 KB, patch)
2021-01-29 14:16 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2021-01-29 12:57:38 PST 
SourceParseMode should be a member of the JSC::Parser
Comment 1 Keith Miller 2021-01-29 12:59:51 PST 
Created attachment 418762 [details]
Patch
Comment 2 Ross Kirsling 2021-01-29 14:06:57 PST 
Comment on attachment 418762 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418762&action=review

LGTM overall.

> Source/JavaScriptCore/parser/Parser.h:1172
> +    using ParseModeScope = SetForScope<SourceParseMode>;

I think this might be more confusing than helpful.
Comment 3 Keith Miller 2021-01-29 14:15:43 PST 
Created attachment 418771 [details]
Patch
Comment 4 Keith Miller 2021-01-29 14:16:57 PST 
Created attachment 418772 [details]
Patch for landing
Comment 5 EWS 2021-01-29 16:36:12 PST 
Committed r272086: <https://trac.webkit.org/changeset/272086>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418772 [details].
Comment 6 Radar WebKit Bug Importer 2021-01-29 16:37:13 PST 
<rdar://problem/73777391>