Bug 221138 - Recover WebRTC codecs in case of GPUProcess crash
Summary: Recover WebRTC codecs in case of GPUProcess crash
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-29 09:06 PST by youenn fablet
Modified: 2021-02-02 03:01 PST (History)
4 users (show)

See Also:

Attachments
Patch (25.58 KB, patch)
2021-01-29 09:15 PST, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (27.69 KB, patch)
2021-01-29 12:42 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (28.71 KB, patch)
2021-01-29 13:24 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (29.61 KB, patch)
2021-02-01 00:47 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (29.62 KB, patch)
2021-02-02 02:08 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-01-29 09:06:31 PST 
Recover WebRTC codecs in case of GPUProcess crash
Comment 1 youenn fablet 2021-01-29 09:15:37 PST 
Created attachment 418735 [details]
Patch
Comment 2 youenn fablet 2021-01-29 12:42:47 PST 
Created attachment 418757 [details]
Patch
Comment 3 youenn fablet 2021-01-29 13:24:50 PST 
Created attachment 418765 [details]
Patch
Comment 4 youenn fablet 2021-02-01 00:47:34 PST 
Created attachment 418840 [details]
Patch
Comment 5 Eric Carlson 2021-02-01 09:00:16 PST 
Comment on attachment 418840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418840&action=review

``

> Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:473
> +    m_queue->dispatch([this, connection = makeRef(gpuConnection.connection())] {

Nit: why not `dispatchToThread` as you do elsewhere?
Comment 6 youenn fablet 2021-02-02 02:08:29 PST 
Created attachment 418975 [details]
Patch for landing
Comment 7 EWS 2021-02-02 03:00:19 PST 
Committed r272202: <https://trac.webkit.org/changeset/272202>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418975 [details].
Comment 8 Radar WebKit Bug Importer 2021-02-02 03:01:18 PST 
<rdar://problem/73872551>