Bug 22112 - if a <body> has contenteditable=true, it should report a writable AXValue
Summary: if a <body> has contenteditable=true, it should report a writable AXValue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 22113 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-11-06 12:35 PST by chris fleizach
Modified: 2008-11-06 14:17 PST (History)
0 users

See Also:

Attachments
patch to make web areas have writable AXValue if contenteditable exists (9.50 KB, patch)
2008-11-06 12:41 PST, chris fleizach 		bdakin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2008-11-06 12:35:26 PST 
This will allow assistive apps to know how to treat the web area
Comment 1 chris fleizach 2008-11-06 12:38:25 PST 
*** Bug 22113 has been marked as a duplicate of this bug. ***
Comment 2 chris fleizach 2008-11-06 12:41:13 PST 
Created attachment 24954 [details]
patch to make web areas have writable AXValue if contenteditable exists
Comment 3 Beth Dakin 2008-11-06 13:58:34 PST 
Comment on attachment 24954 [details]
patch to make web areas have writable AXValue if contenteditable exists

> Index: WebCore/page/AccessibilityRenderObject.cpp
> ===================================================================
> --- WebCore/page/AccessibilityRenderObject.cpp	(revision 38190)
> +++ WebCore/page/AccessibilityRenderObject.cpp	(working copy)
> @@ -341,6 +341,10 @@ bool AccessibilityRenderObject::isReadOn
>          if (!document)
>              return true;
>          
> +        HTMLElement *body = document->body();
> +        if (body && body->isContentEditable())
> +            return false;
> +        
>          Frame* frame = document->frame();
>          if (!frame)
>              return true;


You should move the star -- should be: HTMLElement* body =…


> Index: WebKitTools/DumpRenderTree/AccessibilityUIElement.h
> ===================================================================
> --- WebKitTools/DumpRenderTree/AccessibilityUIElement.h	(revision 38190)
> +++ WebKitTools/DumpRenderTree/AccessibilityUIElement.h	(working copy)
> @@ -69,8 +69,10 @@ public:
>      JSStringRef attributesOfDocumentLinks();
>      JSStringRef attributesOfChildren();
>      JSStringRef parameterizedAttributeNames();
> -    
> +       


You should fix this whitespace change.


r=me
Comment 4 chris fleizach 2008-11-06 14:17:30 PST 
http://trac.webkit.org/changeset/38200