Bug 22111 - [Transforms] Event handling in <video> controls is broken if the video is transformed
Summary: [Transforms] Event handling in <video> controls is broken if the video is tra...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks: 15670
  Show dependency tree / graph
 
Reported: 2008-11-06 12:15 PST by Simon Fraser (smfr)
Modified: 2008-11-19 18:44 PST (History)
0 users

See Also:

Attachments
Testcase (338 bytes, text/html)
2008-11-06 12:19 PST, Simon Fraser (smfr) 		no flags Details
Fixed testcase (386 bytes, text/html)
2008-11-06 12:20 PST, Simon Fraser (smfr) 		no flags Details
Patch, testcase, changelog (6.02 KB, patch)
2008-11-19 18:31 PST, Simon Fraser (smfr) 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2008-11-06 12:15:44 PST 
Video control seem to have event handling issues when the video is transformed, or has a transformed parent. Bug 22109 fixes the slider issues, but there are others (e.g. you can click the play button, and it responds, but the video does not play).
Comment 1 Simon Fraser (smfr) 2008-11-06 12:19:25 PST 
Created attachment 24952 [details]
Testcase
Comment 2 Simon Fraser (smfr) 2008-11-06 12:20:53 PST 
Created attachment 24953 [details]
Fixed testcase
Comment 3 Simon Fraser (smfr) 2008-11-19 18:31:13 PST 
Created attachment 25299 [details]
Patch, testcase, changelog
Comment 4 Antti Koivisto 2008-11-19 18:40:18 PST 
Comment on attachment 25299 [details]
Patch, testcase, changelog

r=me

That FIXME in MediaPlayer could be more enlightening.
Comment 5 Simon Fraser (smfr) 2008-11-19 18:44:45 PST 
Fixed the comment, and committed:
Committed r38612
	M	WebCore/ChangeLog
	M	WebCore/platform/graphics/MediaPlayer.h
	M	WebCore/rendering/RenderMedia.cpp
	A	LayoutTests/media/video-controls-transformed-expected.txt
	A	LayoutTests/media/video-controls-transformed.html
	M	LayoutTests/ChangeLog
r38612 = 154846681526fcb9b0fb6b824768fa0c30f14020 (trunk)