Bug 221105 - Extract color model and transfer functions into their own files
Summary: Extract color model and transfer functions into their own files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-28 14:30 PST by Sam Weinig
Modified: 2021-01-29 10:49 PST (History)
9 users (show)

See Also:

Attachments
Patch (30.20 KB, patch)
2021-01-28 14:32 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (31.47 KB, patch)
2021-01-28 14:34 PST, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (31.55 KB, patch)
2021-01-28 16:16 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (31.55 KB, patch)
2021-01-28 16:28 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (31.82 KB, patch)
2021-01-28 19:00 PST, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (28.66 KB, patch)
2021-01-29 08:59 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2021-01-28 14:30:24 PST 
Extract color model and transfer functions into their own files
Comment 1 Sam Weinig 2021-01-28 14:32:48 PST Comment hidden (obsolete)
Comment 2 Sam Weinig 2021-01-28 14:34:46 PST Comment hidden (obsolete)
Comment 3 Sam Weinig 2021-01-28 16:16:38 PST Comment hidden (obsolete)
Comment 4 Sam Weinig 2021-01-28 16:28:12 PST Comment hidden (obsolete)
Comment 5 Sam Weinig 2021-01-28 19:00:27 PST 
Created attachment 418693 [details]
Patch
Comment 6 Simon Fraser (smfr) 2021-01-28 20:14:35 PST 
Comment on attachment 418693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418693&action=review

> Source/WebCore/ChangeLog:11
> +        Things are getting a bit cramped in ColorTypes.h and ColorConversions.
> +        This extracts the color models into ColorModel.h and gamma transfer 
> +        functions into ColorTransferFunction.h and generalized the transfer
> +        functions a bit to reduce the code size.

Should the new filenames be pluralized?
Comment 7 Sam Weinig 2021-01-29 08:57:48 PST 
(In reply to Simon Fraser (smfr) from comment #6)
> Comment on attachment 418693 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=418693&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        Things are getting a bit cramped in ColorTypes.h and ColorConversions.
> > +        This extracts the color models into ColorModel.h and gamma transfer 
> > +        functions into ColorTransferFunction.h and generalized the transfer
> > +        functions a bit to reduce the code size.
> 
> Should the new filenames be pluralized?

Yeah, that would be more consistent.
Comment 8 Sam Weinig 2021-01-29 08:59:30 PST 
Created attachment 418732 [details]
Patch
Comment 9 EWS 2021-01-29 10:48:20 PST 
Committed r272066: <https://trac.webkit.org/changeset/272066>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418732 [details].
Comment 10 Radar WebKit Bug Importer 2021-01-29 10:49:14 PST 
<rdar://problem/73761809>