Bug 221078 - [JSC] Update test262
Summary: [JSC] Update test262
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-27 20:50 PST by Yusuke Suzuki
Modified: 2021-01-27 21:22 PST (History)
2 users (show)

See Also:

Attachments
Patch (55.34 KB, patch)
2021-01-27 20:51 PST, Yusuke Suzuki 		ashvayka: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-01-27 20:50:45 PST 
[JSC] Update test262
Comment 1 Yusuke Suzuki 2021-01-27 20:51:35 PST 
Created attachment 418613 [details]
Patch
Comment 2 Alexey Shvayka 2021-01-27 20:59:11 PST 
Comment on attachment 418613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418613&action=review

r=me with a comment

> JSTests/ChangeLog:14
> +        * test262/test/built-ins/Array/prototype/sort/precise-getter-appends-elements.js: Added.

Can we please remove all files added to LayoutTests/js in r267514? They are now outdated duplicates.
Comment 3 Yusuke Suzuki 2021-01-27 21:13:24 PST 
Comment on attachment 418613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418613&action=review

>> JSTests/ChangeLog:14
>> +        * test262/test/built-ins/Array/prototype/sort/precise-getter-appends-elements.js: Added.
> 
> Can we please remove all files added to LayoutTests/js in r267514? They are now outdated duplicates.

I think it looks like some of them are different from these tests, for example, the added tests in r267514 includes test for proxy + sort.
I think, for now, having both is OK.
Comment 4 Yusuke Suzuki 2021-01-27 21:18:29 PST 
Landing this since EWS doesn't have test262 bots.
Comment 5 Yusuke Suzuki 2021-01-27 21:21:10 PST 
Committed r272000: <https://trac.webkit.org/changeset/272000>
Comment 6 Radar WebKit Bug Importer 2021-01-27 21:22:15 PST 
<rdar://problem/73694143>