Bug 221064 – Remove some uses of FontSelector from within CSSFontFace

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Remove some uses of FontSelector from within CSSFontFace

[Myles C. Maxfield]

Created attachment 418588 [details]
Patch

[Darin Adler]

Comment on attachment 418588 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418588&action=review

> Source/WebCore/css/CSSFontFace.cpp:98
> +    , m_shouldIgnoreFontLoadCompletions(m_fontSelector && m_fontSelector->document() ? m_fontSelector->document()->settings().shouldIgnoreFontLoadCompletions() : false)

I suggest using && here more instead of using ?: with false.

I suggest using fontSelector here instead of m_fontSelector since you plan to remove the latter.

> Source/WebCore/css/CSSFontFace.cpp:100
> +    , m_allowUserInstalledFonts(m_fontSelector && m_fontSelector->document() && !m_fontSelector->document()->settings().shouldAllowUserInstalledFonts() ? AllowUserInstalledFonts::No : AllowUserInstalledFonts::Yes)

I suggest using fontSelector here instead of m_fontSelector since you plan to remove the latter.

I think we should try to find a way to get to settings that works even when the font selector is nullptr. I think we should also restructure things so the Settings& is an argument to the constructor. We can have one constructor call another, and the one that takes Settings& can be private.

> Source/WebCore/css/CSSFontFace.h:156
> +    bool shouldIgnoreFontLoadCompletions() const { return m_shouldIgnoreFontLoadCompletions; };

Unneeded semicolon here after the closing brace.

[Myles C. Maxfield]

Created attachment 418595 [details]
Patch for committing

[EWS]

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

[Myles C. Maxfield]

Committed r272045: <https://trac.webkit.org/changeset/272045>

[Radar WebKit Bug Importer]

<rdar://problem/73736861>