Bug 221056 - [macOS] Remove reference to deprecated SubmitDiagInfo.domains path
Summary: [macOS] Remove reference to deprecated SubmitDiagInfo.domains path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-27 12:09 PST by Brent Fulgham
Modified: 2021-01-28 09:28 PST (History)
1 user (show)

See Also:


Attachments
Patch (4.49 KB, patch)
2021-01-27 12:12 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2021-01-27 12:09:26 PST
We don't need access to this path, so let's remove it from our sandbox.
Comment 1 Brent Fulgham 2021-01-27 12:11:43 PST
<rdar://problem/73474697>
Comment 2 Brent Fulgham 2021-01-27 12:12:14 PST
Created attachment 418573 [details]
Patch
Comment 3 Per Arne Vollan 2021-01-27 12:13:17 PST
Comment on attachment 418573 [details]
Patch

R=me.
Comment 4 Alexey Proskuryakov 2021-01-27 14:50:59 PST
Comment on attachment 418573 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418573&action=review

> Source/WebKit/ChangeLog:9
> +        macOS does not use SubmitDiagInfo.domains anymore, and even when it did it failed safely.

Does this include all supported macOS versions, or only the latest?
Comment 5 Brent Fulgham 2021-01-28 09:24:50 PST
(In reply to Alexey Proskuryakov from comment #4)
> Comment on attachment 418573 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=418573&action=review
> 
> > Source/WebKit/ChangeLog:9
> > +        macOS does not use SubmitDiagInfo.domains anymore, and even when it did it failed safely.
> 
> Does this include all supported macOS versions, or only the latest?

All supported OS versions.
Comment 6 Brent Fulgham 2021-01-28 09:25:17 PST
(In reply to Brent Fulgham from comment #5)
> (In reply to Alexey Proskuryakov from comment #4)
> > Comment on attachment 418573 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=418573&action=review
> > 
> > > Source/WebKit/ChangeLog:9
> > > +        macOS does not use SubmitDiagInfo.domains anymore, and even when it did it failed safely.
> > 
> > Does this include all supported macOS versions, or only the latest?
> 
> All supported OS versions.
(According to the responsible team using this path).
Comment 7 EWS 2021-01-28 09:28:36 PST
Committed r272016: <https://trac.webkit.org/changeset/272016>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418573 [details].