Bug 221048 - [GPUProcess] Move ownership of RingBuffer backing used by RemoteAudioSourceProviderManager::RemoteAudio to WebProcess
Summary: [GPUProcess] Move ownership of RingBuffer backing used by RemoteAudioSourcePr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-27 10:27 PST by Chris Dumez
Modified: 2022-05-27 07:30 PDT (History)
12 users (show)

See Also:

Attachments
Patch (10.33 KB, patch)
2021-01-27 13:28 PST, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (10.77 KB, patch)
2021-01-27 14:06 PST, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (10.80 KB, patch)
2021-01-27 14:29 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-01-27 10:27:39 PST 
Move ownership of RingBuffer backing used by RemoteAudioSourceProviderManager::RemoteAudio from the GPUProcess to WebProcess, for jetsam purposes. This moves half a megabyte of memory from the GPUProcess to the WebProcess on https://foobar404.github.io/Wave.js.
Comment 1 Chris Dumez 2021-01-27 13:28:07 PST 
Created attachment 418578 [details]
Patch
Comment 2 Chris Dumez 2021-01-27 14:06:57 PST 
Created attachment 418580 [details]
Patch
Comment 3 Chris Dumez 2021-01-27 14:29:37 PST 
Created attachment 418582 [details]
Patch
Comment 4 Geoffrey Garen 2021-01-27 15:05:55 PST 
Comment on attachment 418582 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418582&action=review

r=me

> Source/WebKit/Platform/cocoa/SharedMemoryCocoa.cpp:63
> +    case MemoryLedger::Neural:
> +        return VM_LEDGER_TAG_NEURAL;

Mmmmmm....  Johnny Mnemonic.
Comment 5 EWS 2021-01-27 15:58:08 PST 
Committed r271989: <https://trac.webkit.org/changeset/271989>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418582 [details].
Comment 6 Radar WebKit Bug Importer 2021-01-27 15:59:15 PST 
<rdar://problem/73684206>