Bug 221046 - [iOS] Fix sandbox violation file-read-data /dev/dtracehelper in the Networking process
Summary: [iOS] Fix sandbox violation file-read-data /dev/dtracehelper in the Networkin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-27 09:12 PST by Per Arne Vollan
Modified: 2021-01-27 10:07 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.48 KB, patch)
2021-01-27 09:14 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-01-27 09:12:37 PST 
Reading this file should be allowed in the Networking process on internal installs on iOS.
Comment 1 Per Arne Vollan 2021-01-27 09:13:02 PST 
<rdar://problem/73625718>
Comment 2 Per Arne Vollan 2021-01-27 09:14:33 PST 
Created attachment 418552 [details]
Patch
Comment 3 Brent Fulgham 2021-01-27 09:50:02 PST 
Comment on attachment 418552 [details]
Patch

I think this change looks good, but I think you should take this further and (1) add the apple-internal check in the other places it is used, and (2) add the log silencing check everywhere. You can do that as a follow-up patch is you prefer.
Comment 4 Per Arne Vollan 2021-01-27 10:04:48 PST 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 418552 [details]
> Patch
> 
> I think this change looks good, but I think you should take this further and
> (1) add the apple-internal check in the other places it is used, and (2) add
> the log silencing check everywhere. You can do that as a follow-up patch is
> you prefer.

I will post a follow up patch.

Thanks for reviewing!
Comment 5 EWS 2021-01-27 10:07:42 PST 
Committed r271964: <https://trac.webkit.org/changeset/271964>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418552 [details].