RESOLVED FIXED221045
[macOS] WebContent sandbox regex incorrect 
https://bugs.webkit.org/show_bug.cgi?id=221045
Summary [macOS] WebContent sandbox regex incorrect
Per Arne Vollan
Reported 2021-01-27 08:57:20 PST
When the regex is intended to match the character '.', the pattern '\.' should be used.
Attachments
Patch (1.91 KB, patch)
2021-01-27 08:58 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2021-01-27 08:57:43 PST
<rdar://problem/73473985>
Per Arne Vollan
Comment 2 2021-01-27 08:58:53 PST
Created attachment 418551 [details] Patch
Brent Fulgham
Comment 3 2021-01-27 09:47:26 PST
Comment on attachment 418551 [details] Patch r=me. I'm embarrassed because I think I introduced those years ago. We might also consider switching away from regex, as the Sandbox team told us there are performance costs to using them.
Per Arne Vollan
Comment 4 2021-01-27 10:03:46 PST
(In reply to Brent Fulgham from comment #3) > Comment on attachment 418551 [details] > Patch > > r=me. I'm embarrassed because I think I introduced those years ago. We might > also consider switching away from regex, as the Sandbox team told us there > are performance costs to using them. These are easily mixed up in regex :) Yes, we should also look into switching away from regex. Thanks for reviewing!
EWS
Comment 5 2021-01-27 10:07:22 PST
Committed r271963: <https://trac.webkit.org/changeset/271963> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418551 [details].
Note You need to log in before you can comment on or make changes to this bug.