Bug 221026 - Use SFTranscription instead of SFTranscriptionSegment for SpeechRecognitionAlternative
Summary: Use SFTranscription instead of SFTranscriptionSegment for SpeechRecognitionAl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-27 00:44 PST by Sihui Liu
Modified: 2021-01-27 09:40 PST (History)
2 users (show)

See Also:

Attachments
Patch (5.03 KB, patch)
2021-01-27 00:56 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2021-01-27 00:44:03 PST 
...
Comment 1 Sihui Liu 2021-01-27 00:56:52 PST 
Created attachment 418512 [details]
Patch
Comment 2 youenn fablet 2021-01-27 01:10:55 PST 
Comment on attachment 418512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418512&action=review

> Source/WebCore/ChangeLog:8
> +        So SpeechRecognitionAlternative contains a sentence instead of a word, which matches Blink's behavior.

Does this work well with websites doing word concatenation with space themselves?
Comment 3 Sihui Liu 2021-01-27 08:45:46 PST 
(In reply to youenn fablet from comment #2)
> Comment on attachment 418512 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=418512&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        So SpeechRecognitionAlternative contains a sentence instead of a word, which matches Blink's behavior.
> 
> Does this work well with websites doing word concatenation with space
> themselves?

Yes, because in this case they just insert spaces between sentences while concatenating them.
Comment 4 EWS 2021-01-27 09:39:28 PST 
Committed r271958: <https://trac.webkit.org/changeset/271958>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418512 [details].
Comment 5 Radar WebKit Bug Importer 2021-01-27 09:40:15 PST 
<rdar://problem/73665700>