Bug 221015 - [iOS] expose existing macOS-only `-[WKWebView _pageExtendedBackgroundColor]` SPI
Summary: [iOS] expose existing macOS-only `-[WKWebView _pageExtendedBackgroundColor]` SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-26 15:49 PST by Devin Rousso
Modified: 2021-01-27 12:10 PST (History)
3 users (show)

See Also:

Attachments
Patch (27.67 KB, patch)
2021-01-26 17:06 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-01-26 15:49:30 PST 
.
Comment 1 Radar WebKit Bug Importer 2021-01-26 15:49:52 PST 
<rdar://problem/73636453>
Comment 2 Devin Rousso 2021-01-26 17:06:39 PST 
Created attachment 418491 [details]
Patch
Comment 3 Tim Horton 2021-01-26 17:15:13 PST 
Comment on attachment 418491 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418491&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:383
> +@property (nonatomic, readonly) NSColor *_pageExtendedBackgroundColor;

Might as well rectify past mistakes and add the availability for the macOS version too (blame the line and see when it was introduced).
Comment 4 Devin Rousso 2021-01-26 17:51:37 PST 
Comment on attachment 418491 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418491&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:383
>> +@property (nonatomic, readonly) NSColor *_pageExtendedBackgroundColor;
> 
> Might as well rectify past mistakes and add the availability for the macOS version too (blame the line and see when it was introduced).

AFAICT this appears to have existed as long as `WKWebView` has existed.  It was added seven years ago in r165083.
Comment 5 EWS 2021-01-27 12:10:38 PST 
Committed r271969: <https://trac.webkit.org/changeset/271969>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418491 [details].