WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
221015
[iOS] expose existing macOS-only `-[WKWebView _pageExtendedBackgroundColor]` SPI
https://bugs.webkit.org/show_bug.cgi?id=221015
Summary
[iOS] expose existing macOS-only `-[WKWebView _pageExtendedBackgroundColor]` SPI
Devin Rousso
Reported
2021-01-26 15:49:30 PST
.
Attachments
Patch
(27.67 KB, patch)
2021-01-26 17:06 PST
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2021-01-26 15:49:52 PST
<
rdar://problem/73636453
>
Devin Rousso
Comment 2
2021-01-26 17:06:39 PST
Created
attachment 418491
[details]
Patch
Tim Horton
Comment 3
2021-01-26 17:15:13 PST
Comment on
attachment 418491
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=418491&action=review
> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:383 > +@property (nonatomic, readonly) NSColor *_pageExtendedBackgroundColor;
Might as well rectify past mistakes and add the availability for the macOS version too (blame the line and see when it was introduced).
Devin Rousso
Comment 4
2021-01-26 17:51:37 PST
Comment on
attachment 418491
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=418491&action=review
>> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:383 >> +@property (nonatomic, readonly) NSColor *_pageExtendedBackgroundColor; > > Might as well rectify past mistakes and add the availability for the macOS version too (blame the line and see when it was introduced).
AFAICT this appears to have existed as long as `WKWebView` has existed. It was added seven years ago in
r165083
.
EWS
Comment 5
2021-01-27 12:10:38 PST
Committed
r271969
: <
https://trac.webkit.org/changeset/271969
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 418491
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug